summaryrefslogtreecommitdiff
path: root/pkg/api/handlers
diff options
context:
space:
mode:
authorOpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>2020-02-18 19:00:16 +0100
committerGitHub <noreply@github.com>2020-02-18 19:00:16 +0100
commita5d55966bde3b0798f9cb89009d443ccfac3126a (patch)
treecf5812921f0667c97ec846e11a4a20153090cc5f /pkg/api/handlers
parent5dacee93950a97ea14180bb86f21e462101fe5ea (diff)
parent024ddda123bcc1e042451f1990973291200fa090 (diff)
downloadpodman-a5d55966bde3b0798f9cb89009d443ccfac3126a.tar.gz
podman-a5d55966bde3b0798f9cb89009d443ccfac3126a.tar.bz2
podman-a5d55966bde3b0798f9cb89009d443ccfac3126a.zip
Merge pull request #5235 from jwhonce/issues/5229
Update mux rules to allow slashes in image names
Diffstat (limited to 'pkg/api/handlers')
-rw-r--r--pkg/api/handlers/images.go2
-rw-r--r--pkg/api/handlers/utils/images.go6
2 files changed, 6 insertions, 2 deletions
diff --git a/pkg/api/handlers/images.go b/pkg/api/handlers/images.go
index cd3c0b93f..e4e394d68 100644
--- a/pkg/api/handlers/images.go
+++ b/pkg/api/handlers/images.go
@@ -155,7 +155,7 @@ func SearchImages(w http.ResponseWriter, r *http.Request) {
}
results, err := image.SearchImages(query.Term, options)
if err != nil {
- utils.InternalServerError(w, err)
+ utils.BadRequest(w, "term", query.Term, err)
}
utils.WriteResponse(w, http.StatusOK, results)
}
diff --git a/pkg/api/handlers/utils/images.go b/pkg/api/handlers/utils/images.go
index d0dfbf3ab..f68a71561 100644
--- a/pkg/api/handlers/utils/images.go
+++ b/pkg/api/handlers/utils/images.go
@@ -31,12 +31,16 @@ func GetImages(w http.ResponseWriter, r *http.Request) ([]*image.Image, error) {
if _, found := mux.Vars(r)["digests"]; found && query.Digests {
UnSupportedParameter("digests")
}
+
if len(query.Filters) > 0 {
for k, v := range query.Filters {
for _, val := range v {
filters = append(filters, fmt.Sprintf("%s=%s", k, val))
}
}
+ return runtime.ImageRuntime().GetImagesWithFilters(filters)
+ } else {
+ return runtime.ImageRuntime().GetImages()
}
- return runtime.ImageRuntime().GetImagesWithFilters(filters)
+
}