Refacter API server emphasis on logging

* To aid in debugging log API request and response bodies at trace
  level. Events can be correlated using the X-Reference-Id.
* Server now echos X-Reference-Id from client if set, otherwise
  generates an unique id.
* Move logic for X-Reference-Id into middleware
* Change uses of Header.Add() to Set() when setting Content-Type
* Log API operations in Apache format using gorilla middleware
* Port server code to use BaseContext and ConnContext

Fixes #10053

Signed-off-by: Jhon Honce <jhonce@redhat.com>

1 files changed, 8 insertions, 2 deletions

diff --git a/pkg/api/server/idle/tracker.go b/pkg/api/server/idle/tracker.go
index 687ebd7d4..480239f05 100644
--- a/pkg/api/server/idle/tracker.go
+++ b/pkg/api/server/idle/tracker.go
@@ -1,6 +1,7 @@
 package idle
 
 import (
+	"fmt"
 	"net"
 	"net/http"
 	"sync"
@@ -39,7 +40,10 @@ func (t *Tracker) ConnState(conn net.Conn, state http.ConnState) {
 	t.mux.Lock()
 	defer t.mux.Unlock()
 
-	logrus.Debugf("IdleTracker %p:%v %dm+%dh/%dt connection(s)", conn, state, len(t.managed), t.hijacked, t.TotalConnections())
+	logrus.WithFields(logrus.Fields{
+		"X-Reference-Id": fmt.Sprintf("%p", conn),
+	}).Debugf("IdleTracker:%v %dm+%dh/%dt connection(s)", state, len(t.managed), t.hijacked, t.TotalConnections())
+
 	switch state {
 	case http.StateNew:
 		t.total++
@@ -68,7 +72,9 @@ func (t *Tracker) ConnState(conn net.Conn, state http.ConnState) {
 			if _, found := t.managed[conn]; found {
 				delete(t.managed, conn)
 			} else {
-				logrus.Warnf("IdleTracker %p: StateClosed transition by un-managed connection", conn)
+				logrus.WithFields(logrus.Fields{
+					"X-Reference-Id": fmt.Sprintf("%p", conn),
+				}).Warnf("IdleTracker: StateClosed transition by connection marked un-managed")
 			}
 		}