summaryrefslogtreecommitdiff
path: root/pkg/api
diff options
context:
space:
mode:
authorJake Correnti <jcorrenti13@gmail.com>2022-06-13 13:33:19 -0400
committerMatthew Heon <mheon@redhat.com>2022-06-14 16:12:11 -0400
commit96ccd6934b8f23d5af51514b136ed802647dc47a (patch)
tree3a1828a8d1d814def00cddd56484eb979723e81b /pkg/api
parentef3197885e92a4604823a739cbdc732b41b4ab31 (diff)
downloadpodman-96ccd6934b8f23d5af51514b136ed802647dc47a.tar.gz
podman-96ccd6934b8f23d5af51514b136ed802647dc47a.tar.bz2
podman-96ccd6934b8f23d5af51514b136ed802647dc47a.zip
Non-running containers now report statistics via the `podman stats`
command Previously, if a container was not running, and the user ran the `podman stats` command, an error would be reported: `Error: container state improper`. Podman now reports stats as the fields' default values for their respective type if the container is not running: ``` $ podman stats --no-stream demo ID NAME CPU % MEM USAGE / LIMIT MEM % NET IO BLOCK IO PIDS CPU TIME AVG CPU % 4b4bf8ce84ed demo 0.00% 0B / 0B 0.00% 0B / 0B 0B / 0B 0 0s 0.00% ``` Closes: #14498 Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
Diffstat (limited to 'pkg/api')
-rw-r--r--pkg/api/handlers/compat/containers_stats.go12
1 files changed, 0 insertions, 12 deletions
diff --git a/pkg/api/handlers/compat/containers_stats.go b/pkg/api/handlers/compat/containers_stats.go
index 77b16b03e..6855e369b 100644
--- a/pkg/api/handlers/compat/containers_stats.go
+++ b/pkg/api/handlers/compat/containers_stats.go
@@ -44,18 +44,6 @@ func StatsContainer(w http.ResponseWriter, r *http.Request) {
return
}
- // If the container isn't running, then let's not bother and return
- // immediately.
- state, err := ctnr.State()
- if err != nil {
- utils.InternalServerError(w, err)
- return
- }
- if state != define.ContainerStateRunning {
- utils.Error(w, http.StatusConflict, define.ErrCtrStateInvalid)
- return
- }
-
stats, err := ctnr.GetContainerStats(nil)
if err != nil {
utils.InternalServerError(w, errors.Wrapf(err, "failed to obtain Container %s stats", name))