diff options
| author | Jhon Honce <jhonce@redhat.com> | 2021-08-02 14:09:55 -0700 |
|---|---|---|
| committer | Jhon Honce <jhonce@redhat.com> | 2021-08-24 16:36:10 -0700 |
| commit | 1dc6d14735eef1e51368103aefba3d7c704dcfe3 (patch) | |
| tree | 61109c0b3d99cb3bcf85f53b0f8a837a995b0569 /pkg/bindings/errors.go | |
| parent | e9daaf62e3921b8c696f3abd92f001a9447c8aa1 (diff) | |
| download | podman-1dc6d14735eef1e51368103aefba3d7c704dcfe3.tar.gz podman-1dc6d14735eef1e51368103aefba3d7c704dcfe3.tar.bz2 podman-1dc6d14735eef1e51368103aefba3d7c704dcfe3.zip | |
Fix file descriptor leaks and add test
* Add response.Body.Close() where needed to release HTTP
connections to API server.
* Add tests to ensure no general leaks occur. 100% coverage would be
required to ensure no leaks on any call.
* Update code comments to be godoc correct
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Diffstat (limited to 'pkg/bindings/errors.go')
| -rw-r--r-- | pkg/bindings/errors.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/pkg/bindings/errors.go b/pkg/bindings/errors.go index 3339062a5..9c311d912 100644 --- a/pkg/bindings/errors.go +++ b/pkg/bindings/errors.go @@ -20,6 +20,8 @@ func handleError(data []byte) error { return e } +// Process drains the response body, and processes the HTTP status code +// Note: Closing the response.Body is left to the caller func (h APIResponse) Process(unmarshalInto interface{}) error { data, err := ioutil.ReadAll(h.Response.Body) if err != nil { |