Merge pull request #11103 from jwhonce/wip/bindings

Fix file descriptor leaks in bindings and add test

1 files changed, 17 insertions, 4 deletions

diff --git a/pkg/bindings/manifests/manifests.go b/pkg/bindings/manifests/manifests.go
index 268ce3b19..6aa4961f1 100644
--- a/pkg/bindings/manifests/manifests.go
+++ b/pkg/bindings/manifests/manifests.go
@@ -46,10 +46,12 @@ func Create(ctx context.Context, names, images []string, options *CreateOptions)
 	if err != nil {
 		return "", err
 	}
+	defer response.Body.Close()
+
 	return idr.ID, response.Process(&idr)
 }
 
-// Exists returns true if a given maifest list exists
+// Exists returns true if a given manifest list exists
 func Exists(ctx context.Context, name string, options *ExistsOptions) (bool, error) {
 	conn, err := bindings.GetClient(ctx)
 	if err != nil {
@@ -59,6 +61,8 @@ func Exists(ctx context.Context, name string, options *ExistsOptions) (bool, err
 	if err != nil {
 		return false, err
 	}
+	defer response.Body.Close()
+
 	return response.IsSuccess(), nil
 }
 
@@ -77,6 +81,8 @@ func Inspect(ctx context.Context, name string, options *InspectOptions) (*manife
 	if err != nil {
 		return nil, err
 	}
+	defer response.Body.Close()
+
 	return &list, response.Process(&list)
 }
 
@@ -100,6 +106,8 @@ func Add(ctx context.Context, name string, options *AddOptions) (string, error)
 	if err != nil {
 		return "", err
 	}
+	defer response.Body.Close()
+
 	return idr.ID, response.Process(&idr)
 }
 
@@ -121,6 +129,8 @@ func Remove(ctx context.Context, name, digest string, options *RemoveOptions) (s
 	if err != nil {
 		return "", err
 	}
+	defer response.Body.Close()
+
 	return idr.ID, response.Process(&idr)
 }
 
@@ -145,18 +155,20 @@ func Push(ctx context.Context, name, destination string, options *images.PushOpt
 	if err != nil {
 		return "", err
 	}
-	//SkipTLSVerify is special.  We need to delete the param added by
-	//toparams and change the key and flip the bool
+	// SkipTLSVerify is special.  We need to delete the param added by
+	// toparams and change the key and flip the bool
 	if options.SkipTLSVerify != nil {
 		params.Del("SkipTLSVerify")
 		params.Set("tlsVerify", strconv.FormatBool(!options.GetSkipTLSVerify()))
 	}
 	params.Set("image", name)
 	params.Set("destination", destination)
-	_, err = conn.DoRequest(nil, http.MethodPost, "/manifests/%s/push", params, nil, name)
+	response, err := conn.DoRequest(nil, http.MethodPost, "/manifests/%s/push", params, nil, name)
 	if err != nil {
 		return "", err
 	}
+	defer response.Body.Close()
+
 	return idr.ID, err
 }
 
@@ -179,5 +191,6 @@ func Push(ctx context.Context, name, destination string, options *images.PushOpt
 //	if err != nil {
 //		return "", err
 //	}
+//  defer response.Body.Close()
 //	return idr.ID, response.Process(&idr)
 //}