diff options
| author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2021-08-25 14:42:12 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-25 14:42:12 -0400 |
| commit | 49cfed756f5dfb6d9267eb29d31f651578c9037c (patch) | |
| tree | 677b6acfee4b6fddc1b08d8181ce3552a5ccab68 /pkg/bindings/system/info.go | |
| parent | fefa0b32c74fc5d394a0e2bd5b4564bedb3ed15d (diff) | |
| parent | 1dc6d14735eef1e51368103aefba3d7c704dcfe3 (diff) | |
| download | podman-49cfed756f5dfb6d9267eb29d31f651578c9037c.tar.gz podman-49cfed756f5dfb6d9267eb29d31f651578c9037c.tar.bz2 podman-49cfed756f5dfb6d9267eb29d31f651578c9037c.zip | |
Merge pull request #11103 from jwhonce/wip/bindings
Fix file descriptor leaks in bindings and add test
Diffstat (limited to 'pkg/bindings/system/info.go')
| -rw-r--r-- | pkg/bindings/system/info.go | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/pkg/bindings/system/info.go b/pkg/bindings/system/info.go index 244f9643e..8a307a4ca 100644 --- a/pkg/bindings/system/info.go +++ b/pkg/bindings/system/info.go @@ -9,12 +9,7 @@ import ( ) // Info returns information about the libpod environment and its stores -func Info(ctx context.Context, options *InfoOptions) (*define.Info, error) { - if options == nil { - options = new(InfoOptions) - } - _ = options - info := define.Info{} +func Info(ctx context.Context, _ *InfoOptions) (*define.Info, error) { conn, err := bindings.GetClient(ctx) if err != nil { return nil, err @@ -23,5 +18,8 @@ func Info(ctx context.Context, options *InfoOptions) (*define.Info, error) { if err != nil { return nil, err } + defer response.Body.Close() + + info := define.Info{} return &info, response.Process(&info) } |