add default network for apiv2 create

during container creation, if no network is provided, we need to add a default value so the container can be later started.

use apiv2 container creation for RunTopContainer instead of an exec to the system podman. RunTopContainer now also returns the container id and an error.

added a libpod commit endpoint.

also, changed the use of the connections and bindings slightly to make it more convenient to write tests.

Fixes: 5366
Signed-off-by: Brent Baude <bbaude@redhat.com>

1 files changed, 50 insertions, 0 deletions

diff --git a/pkg/bindings/test/create_test.go b/pkg/bindings/test/create_test.go
new file mode 100644
index 000000000..f83a9b14d
--- /dev/null
+++ b/pkg/bindings/test/create_test.go
@@ -0,0 +1,50 @@
+package test_bindings
+
+import (
+	"time"
+
+	"github.com/containers/libpod/pkg/bindings/containers"
+	"github.com/containers/libpod/pkg/specgen"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"github.com/onsi/gomega/gexec"
+)
+
+var _ = Describe("Create containers ", func() {
+	var (
+		bt *bindingTest
+		s  *gexec.Session
+	)
+
+	BeforeEach(func() {
+		bt = newBindingTest()
+		bt.RestoreImagesFromCache()
+		s = bt.startAPIService()
+		time.Sleep(1 * time.Second)
+		err := bt.NewConnection()
+		Expect(err).To(BeNil())
+	})
+
+	AfterEach(func() {
+		s.Kill()
+		bt.cleanup()
+	})
+
+	It("create a container running top", func() {
+		s := specgen.NewSpecGenerator(alpine.name)
+		s.Command = []string{"top"}
+		s.Terminal = true
+		s.Name = "top"
+		ctr, err := containers.CreateWithSpec(bt.conn, s)
+		Expect(err).To(BeNil())
+		data, err := containers.Inspect(bt.conn, ctr.ID, nil)
+		Expect(err).To(BeNil())
+		Expect(data.Name).To(Equal("top"))
+		err = containers.Start(bt.conn, ctr.ID, nil)
+		Expect(err).To(BeNil())
+		data, err = containers.Inspect(bt.conn, ctr.ID, nil)
+		Expect(err).To(BeNil())
+		Expect(data.State.Status).To(Equal("running"))
+	})
+
+})