refactor info

the current implementation of info, while typed, is very loosely done so.  we need stronger types for our apiv2 implmentation and bindings.

Signed-off-by: Brent Baude <bbaude@redhat.com>

3 files changed, 96 insertions, 3 deletions

diff --git a/pkg/bindings/info.go b/pkg/bindings/info.go
deleted file mode 100644
index 5f318d652..000000000
--- a/pkg/bindings/info.go
+++ /dev/null
@@ -1,3 +0,0 @@
-package bindings
-
-func (c Connection) Info() {}
diff --git a/pkg/bindings/system/info.go b/pkg/bindings/system/info.go
new file mode 100644
index 000000000..f8269cfd8
--- /dev/null
+++ b/pkg/bindings/system/info.go
@@ -0,0 +1,23 @@
+package system
+
+import (
+	"context"
+	"net/http"
+
+	"github.com/containers/libpod/libpod/define"
+	"github.com/containers/libpod/pkg/bindings"
+)
+
+// Info returns information about the libpod environment and its stores
+func Info(ctx context.Context) (define.Info, error) {
+	info := define.Info{}
+	conn, err := bindings.GetClient(ctx)
+	if err != nil {
+		return info, err
+	}
+	response, err := conn.DoRequest(nil, http.MethodGet, "/info", nil)
+	if err != nil {
+		return info, err
+	}
+	return info, response.Process(&info)
+}
diff --git a/pkg/bindings/test/info_test.go b/pkg/bindings/test/info_test.go
new file mode 100644
index 000000000..d0e651134
--- /dev/null
+++ b/pkg/bindings/test/info_test.go
@@ -0,0 +1,73 @@
+package test_bindings
+
+import (
+	"runtime"
+	"time"
+
+	"github.com/containers/libpod/pkg/bindings/containers"
+	"github.com/containers/libpod/pkg/bindings/images"
+	"github.com/containers/libpod/pkg/bindings/system"
+	"github.com/containers/libpod/pkg/specgen"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+	"github.com/onsi/gomega/gexec"
+)
+
+var _ = Describe("Podman info", func() {
+	var (
+		bt *bindingTest
+		s  *gexec.Session
+		t  bool = true
+	)
+
+	BeforeEach(func() {
+		bt = newBindingTest()
+		bt.RestoreImagesFromCache()
+		s = bt.startAPIService()
+		time.Sleep(1 * time.Second)
+		err := bt.NewConnection()
+		Expect(err).To(BeNil())
+	})
+
+	AfterEach(func() {
+		s.Kill()
+		bt.cleanup()
+	})
+
+	It("podman info", func() {
+		info, err := system.Info(bt.conn)
+		Expect(err).To(BeNil())
+		Expect(info.Host.Arch).To(Equal(runtime.GOARCH))
+		Expect(info.Host.OS).To(Equal(runtime.GOOS))
+		i, err := images.List(bt.conn, &t, nil)
+		Expect(err).To(BeNil())
+		Expect(info.Store.ImageStore.Number).To(Equal(len(i)))
+	})
+
+	It("podman info container counts", func() {
+		s := specgen.NewSpecGenerator(alpine.name)
+		_, err := containers.CreateWithSpec(bt.conn, s)
+		Expect(err).To(BeNil())
+
+		idPause, err := bt.RunTopContainer(nil, nil, nil)
+		Expect(err).To(BeNil())
+		err = containers.Pause(bt.conn, idPause)
+		Expect(err).To(BeNil())
+
+		idStop, err := bt.RunTopContainer(nil, nil, nil)
+		Expect(err).To(BeNil())
+		err = containers.Stop(bt.conn, idStop, nil)
+		Expect(err).To(BeNil())
+
+		_, err = bt.RunTopContainer(nil, nil, nil)
+		Expect(err).To(BeNil())
+
+		info, err := system.Info(bt.conn)
+		Expect(err).To(BeNil())
+
+		Expect(info.Store.ContainerStore.Number).To(BeNumerically("==", 4))
+		Expect(info.Store.ContainerStore.Paused).To(Equal(1))
+		Expect(info.Store.ContainerStore.Stopped).To(Equal(2))
+		Expect(info.Store.ContainerStore.Running).To(Equal(1))
+	})
+})