diff options
| author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2022-05-24 12:50:59 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-24 12:50:59 -0400 |
| commit | 2dc4f752c67e8e8c1035d6e2d689779cdc00004b (patch) | |
| tree | 69557b4f1002fb85a3cb3c32401adeb7a4484c5b /pkg/bindings | |
| parent | 7391bdfbbc418adbc85f6643cb67cdbd87fd0b7b (diff) | |
| parent | 2400d1d52ff4199778781446445eef39a6e2c6b9 (diff) | |
| download | podman-2dc4f752c67e8e8c1035d6e2d689779cdc00004b.tar.gz podman-2dc4f752c67e8e8c1035d6e2d689779cdc00004b.tar.bz2 podman-2dc4f752c67e8e8c1035d6e2d689779cdc00004b.zip | |
Merge pull request #14341 from vrothberg/todo-part-1
TODO's and FIXME's [PART 1]
Diffstat (limited to 'pkg/bindings')
| -rw-r--r-- | pkg/bindings/images/images.go | 2 | ||||
| -rw-r--r-- | pkg/bindings/images/pull.go | 1 | ||||
| -rw-r--r-- | pkg/bindings/images/rm.go | 3 |
3 files changed, 0 insertions, 6 deletions
diff --git a/pkg/bindings/images/images.go b/pkg/bindings/images/images.go index 8e3b07929..32372019b 100644 --- a/pkg/bindings/images/images.go +++ b/pkg/bindings/images/images.go @@ -280,7 +280,6 @@ func Push(ctx context.Context, source string, destination string, options *PushO if err != nil { return err } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&imageTypes.SystemContext{AuthFilePath: options.GetAuthfile()}, options.GetUsername(), options.GetPassword()) if err != nil { return err @@ -329,7 +328,6 @@ func Search(ctx context.Context, term string, options *SearchOptions) ([]entitie params.Set("tlsVerify", strconv.FormatBool(!options.GetSkipTLSVerify())) } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&imageTypes.SystemContext{AuthFilePath: options.GetAuthfile()}, "", "") if err != nil { return nil, err diff --git a/pkg/bindings/images/pull.go b/pkg/bindings/images/pull.go index 20e47179c..de02c62fd 100644 --- a/pkg/bindings/images/pull.go +++ b/pkg/bindings/images/pull.go @@ -42,7 +42,6 @@ func Pull(ctx context.Context, rawImage string, options *PullOptions) ([]string, params.Set("tlsVerify", strconv.FormatBool(!options.GetSkipTLSVerify())) } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&types.SystemContext{AuthFilePath: options.GetAuthfile()}, options.GetUsername(), options.GetPassword()) if err != nil { return nil, err diff --git a/pkg/bindings/images/rm.go b/pkg/bindings/images/rm.go index b80bacf45..eb3eef10c 100644 --- a/pkg/bindings/images/rm.go +++ b/pkg/bindings/images/rm.go @@ -16,9 +16,6 @@ func Remove(ctx context.Context, images []string, options *RemoveOptions) (*enti if options == nil { options = new(RemoveOptions) } - // FIXME - bindings tests are missing for this endpoint. Once the CI is - // re-enabled for bindings, we need to add them. At the time of writing, - // the tests don't compile. var report types.LibpodImagesRemoveReport conn, err := bindings.GetClient(ctx) if err != nil { |