compat handlers: add X-Registry-Auth header support

 * Support the `X-Registry-Auth` http-request header.

 * The content of the header is a base64 encoded JSON payload which can
   either be a single auth config or a map of auth configs (user+pw or
   token) with the corresponding registries being the keys.  Vanilla
   Docker, projectatomic Docker and the bindings are transparantly
   supported.

 * Add a hidden `--registries-conf` flag.  Buildah exposes the same
   flag, mostly for testing purposes.

 * Do all credential parsing in the client (i.e., `cmd/podman`) pass
   the username and password in the backend instead of unparsed
   credentials.

 * Add a `pkg/auth` which handles most of the heavy lifting.

 * Go through the authentication-handling code of most commands, bindings
   and endpoints.  Migrate them to the new code and fix issues as seen.
   A final evaluation and more tests is still required *after* this
   change.

 * The manifest-push endpoint is missing certain parameters and should
   use the ABI function instead.  Adding auth-support isn't really
   possible without these parts working.

 * The container commands and endpoints (i.e., create and run) have not
   been changed yet.  The APIs don't yet account for the authfile.

 * Add authentication tests to `pkg/bindings`.

Fixes: #6384
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

1 files changed, 9 insertions, 2 deletions

diff --git a/pkg/domain/entities/manifest.go b/pkg/domain/entities/manifest.go
index 273052bb9..853619b19 100644
--- a/pkg/domain/entities/manifest.go
+++ b/pkg/domain/entities/manifest.go
@@ -1,5 +1,9 @@
 package entities
 
+import "github.com/containers/image/v5/types"
+
+// TODO: add comments to *all* types and fields.
+
 type ManifestCreateOptions struct {
 	All bool `schema:"all"`
 }
@@ -26,6 +30,9 @@ type ManifestAnnotateOptions struct {
 }
 
 type ManifestPushOptions struct {
-	Purge, Quiet, All, TlsVerify, RemoveSignatures       bool
-	Authfile, CertDir, Creds, DigestFile, Format, SignBy string
+	Purge, Quiet, All, RemoveSignatures bool
+
+	Authfile, CertDir, Username, Password, DigestFile, Format, SignBy string
+
+	SkipTLSVerify types.OptionalBool
 }