Merge pull request #5571 from baude/v2exists

podmanv2 container exists|wait

3 files changed, 28 insertions, 17 deletions

diff --git a/pkg/domain/entities/containers.go b/pkg/domain/entities/containers.go
index 1899b98f7..0e1208b3b 100644
--- a/pkg/domain/entities/containers.go
+++ b/pkg/domain/entities/containers.go
@@ -1 +1,23 @@
 package entities
+
+import (
+	"time"
+
+	"github.com/containers/libpod/libpod/define"
+)
+
+type WaitOptions struct {
+	Condition define.ContainerStatus
+	Interval  time.Duration
+	Latest    bool
+}
+
+type WaitReport struct {
+	Id       string
+	Error    error
+	ExitCode int32
+}
+
+type BoolReport struct {
+	Value bool
+}
diff --git a/pkg/domain/entities/engine.go b/pkg/domain/entities/engine.go
index a1096f1f1..08ef1df92 100644
--- a/pkg/domain/entities/engine.go
+++ b/pkg/domain/entities/engine.go
@@ -1,7 +1,6 @@
 package entities
 
 import (
-	"net/url"
 	"os/user"
 	"path/filepath"
 
@@ -20,11 +19,13 @@ func (m EngineMode) String() string {
 	return string(m)
 }
 
+// FIXME: merge EngineOptions and EngineFlags
 type EngineOptions struct {
-	Uri        *url.URL
+	Uri        string
 	Identities []string
-	FlagSet    pflag.FlagSet
+	FlagSet    *pflag.FlagSet
 	Flags      EngineFlags
+	EngineMode EngineMode
 }
 
 type EngineFlags struct {
@@ -58,8 +59,6 @@ type EngineFlags struct {
 	Port                 int
 	IdentityFile         string
 	IgnoreHosts          bool
-
-	EngineMode EngineMode
 }
 
 func NewEngineOptions() (EngineFlags, error) {
diff --git a/pkg/domain/entities/engine_container.go b/pkg/domain/entities/engine_container.go
index d08f37d44..aa2ceb630 100644
--- a/pkg/domain/entities/engine_container.go
+++ b/pkg/domain/entities/engine_container.go
@@ -5,22 +5,12 @@ import (
 )
 
 type ContainerEngine interface {
-	ContainerRuntime
-	PodRuntime
-	VolumeRuntime
-}
-
-type ContainerRuntime interface {
 	ContainerDelete(ctx context.Context, opts ContainerDeleteOptions) (*ContainerDeleteReport, error)
 	ContainerPrune(ctx context.Context) (*ContainerPruneReport, error)
-}
-
-type PodRuntime interface {
+	ContainerExists(ctx context.Context, nameOrId string) (*BoolReport, error)
+	ContainerWait(ctx context.Context, namesOrIds []string, options WaitOptions) ([]WaitReport, error)
 	PodDelete(ctx context.Context, opts PodPruneOptions) (*PodDeleteReport, error)
 	PodPrune(ctx context.Context) (*PodPruneReport, error)
-}
-
-type VolumeRuntime interface {
 	VolumeDelete(ctx context.Context, opts VolumeDeleteOptions) (*VolumeDeleteReport, error)
 	VolumePrune(ctx context.Context) (*VolumePruneReport, error)
 }