compat handlers: add X-Registry-Auth header support

 * Support the `X-Registry-Auth` http-request header.

 * The content of the header is a base64 encoded JSON payload which can
   either be a single auth config or a map of auth configs (user+pw or
   token) with the corresponding registries being the keys.  Vanilla
   Docker, projectatomic Docker and the bindings are transparantly
   supported.

 * Add a hidden `--registries-conf` flag.  Buildah exposes the same
   flag, mostly for testing purposes.

 * Do all credential parsing in the client (i.e., `cmd/podman`) pass
   the username and password in the backend instead of unparsed
   credentials.

 * Add a `pkg/auth` which handles most of the heavy lifting.

 * Go through the authentication-handling code of most commands, bindings
   and endpoints.  Migrate them to the new code and fix issues as seen.
   A final evaluation and more tests is still required *after* this
   change.

 * The manifest-push endpoint is missing certain parameters and should
   use the ABI function instead.  Adding auth-support isn't really
   possible without these parts working.

 * The container commands and endpoints (i.e., create and run) have not
   been changed yet.  The APIs don't yet account for the authfile.

 * Add authentication tests to `pkg/bindings`.

Fixes: #6384
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

5 files changed, 41 insertions, 24 deletions

diff --git a/pkg/domain/entities/engine.go b/pkg/domain/entities/engine.go
index 265c9f36f..db58befa5 100644
--- a/pkg/domain/entities/engine.go
+++ b/pkg/domain/entities/engine.go
@@ -37,19 +37,20 @@ type PodmanConfig struct {
 	*config.Config
 	*pflag.FlagSet
 
-	CGroupUsage string           // rootless code determines Usage message
-	ConmonPath  string           // --conmon flag will set Engine.ConmonPath
-	CpuProfile  string           // Hidden: Should CPU profile be taken
-	EngineMode  EngineMode       // ABI or Tunneling mode
-	Identities  []string         // ssh identities for connecting to server
-	MaxWorks    int              // maximum number of parallel threads
-	RuntimePath string           // --runtime flag will set Engine.RuntimePath
-	SpanCloser  io.Closer        // Close() for tracing object
-	SpanCtx     context.Context  // context to use when tracing
-	Span        opentracing.Span // tracing object
-	Syslog      bool             // write to StdOut and Syslog, not supported when tunneling
-	Trace       bool             // Hidden: Trace execution
-	Uri         string           // URI to API Service
+	CGroupUsage    string           // rootless code determines Usage message
+	ConmonPath     string           // --conmon flag will set Engine.ConmonPath
+	CpuProfile     string           // Hidden: Should CPU profile be taken
+	EngineMode     EngineMode       // ABI or Tunneling mode
+	Identities     []string         // ssh identities for connecting to server
+	MaxWorks       int              // maximum number of parallel threads
+	RegistriesConf string           // allows for specifying a custom registries.conf
+	RuntimePath    string           // --runtime flag will set Engine.RuntimePath
+	SpanCloser     io.Closer        // Close() for tracing object
+	SpanCtx        context.Context  // context to use when tracing
+	Span           opentracing.Span // tracing object
+	Syslog         bool             // write to StdOut and Syslog, not supported when tunneling
+	Trace          bool             // Hidden: Trace execution
+	Uri            string           // URI to API Service
 
 	Runroot       string
 	StorageDriver string
diff --git a/pkg/domain/entities/images.go b/pkg/domain/entities/images.go
index 968bcff3b..19a2c87f5 100644
--- a/pkg/domain/entities/images.go
+++ b/pkg/domain/entities/images.go
@@ -128,9 +128,10 @@ type ImagePullOptions struct {
 	// CertDir is the path to certificate directories.  Ignored for remote
 	// calls.
 	CertDir string
-	// Credentials for authenticating against the registry in the format
-	// USERNAME:PASSWORD.
-	Credentials string
+	// Username for authenticating against the registry.
+	Username string
+	// Password for authenticating against the registry.
+	Password string
 	// OverrideArch will overwrite the local architecture for image pulls.
 	OverrideArch string
 	// OverrideOS will overwrite the local operating system (OS) for image
@@ -162,9 +163,10 @@ type ImagePushOptions struct {
 	// transport. Default is same compression type as source. Ignored for remote
 	// calls.
 	Compress bool
-	// Credentials for authenticating against the registry in the format
-	// USERNAME:PASSWORD.
-	Credentials string
+	// Username for authenticating against the registry.
+	Username string
+	// Password for authenticating against the registry.
+	Password string
 	// DigestFile, after copying the image, write the digest of the resulting
 	// image to the file.  Ignored for remote calls.
 	DigestFile string
diff --git a/pkg/domain/entities/manifest.go b/pkg/domain/entities/manifest.go
index 273052bb9..853619b19 100644
--- a/pkg/domain/entities/manifest.go
+++ b/pkg/domain/entities/manifest.go
@@ -1,5 +1,9 @@
 package entities
 
+import "github.com/containers/image/v5/types"
+
+// TODO: add comments to *all* types and fields.
+
 type ManifestCreateOptions struct {
 	All bool `schema:"all"`
 }
@@ -26,6 +30,9 @@ type ManifestAnnotateOptions struct {
 }
 
 type ManifestPushOptions struct {
-	Purge, Quiet, All, TlsVerify, RemoveSignatures       bool
-	Authfile, CertDir, Creds, DigestFile, Format, SignBy string
+	Purge, Quiet, All, RemoveSignatures bool
+
+	Authfile, CertDir, Username, Password, DigestFile, Format, SignBy string
+
+	SkipTLSVerify types.OptionalBool
 }
diff --git a/pkg/domain/entities/play.go b/pkg/domain/entities/play.go
index 93864c23b..4f485cbee 100644
--- a/pkg/domain/entities/play.go
+++ b/pkg/domain/entities/play.go
@@ -8,9 +8,10 @@ type PlayKubeOptions struct {
 	Authfile string
 	// CertDir - to a directory containing TLS certifications and keys.
 	CertDir string
-	// Credentials - `username:password` for authentication against a
-	// container registry.
-	Credentials string
+	// Username for authenticating against the registry.
+	Username string
+	// Password for authenticating against the registry.
+	Password string
 	// Network - name of the CNI network to connect to.
 	Network string
 	// Quiet - suppress output when pulling images.
diff --git a/pkg/domain/entities/system.go b/pkg/domain/entities/system.go
index 5e4760d12..79a90be48 100644
--- a/pkg/domain/entities/system.go
+++ b/pkg/domain/entities/system.go
@@ -97,3 +97,9 @@ type SystemVersionReport struct {
 type ComponentVersion struct {
 	types.Version
 }
+
+// ListRegistriesReport is the report when querying for a sorted list of
+// registries which may be contacted during certain operations.
+type ListRegistriesReport struct {
+	Registries []string
+}