diff options
author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2020-04-29 11:21:47 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-04-29 11:21:47 +0200 |
commit | 3e912f711b875b40709075e22be3f94e21e1639a (patch) | |
tree | 535357ded8c2482fabd8a9ccda5cdd70bb94867f /pkg/domain/infra/abi | |
parent | 62a4befe040944c7c4883fed6a70f691aadb440c (diff) | |
parent | 8700c2fd03c29fb898f93e71618d91e2470236f6 (diff) | |
download | podman-3e912f711b875b40709075e22be3f94e21e1639a.tar.gz podman-3e912f711b875b40709075e22be3f94e21e1639a.tar.bz2 podman-3e912f711b875b40709075e22be3f94e21e1639a.zip |
Merge pull request #6022 from vrothberg/enable-inspect-tests
enable inspect tests
Diffstat (limited to 'pkg/domain/infra/abi')
-rw-r--r-- | pkg/domain/infra/abi/images.go | 31 |
1 files changed, 13 insertions, 18 deletions
diff --git a/pkg/domain/infra/abi/images.go b/pkg/domain/infra/abi/images.go index 7ac111745..7c63276e5 100644 --- a/pkg/domain/infra/abi/images.go +++ b/pkg/domain/infra/abi/images.go @@ -170,29 +170,24 @@ func (ir *ImageEngine) Pull(ctx context.Context, rawImage string, options entiti return &entities.ImagePullReport{Images: foundIDs}, nil } -func (ir *ImageEngine) Inspect(ctx context.Context, names []string, opts entities.InspectOptions) (*entities.ImageInspectReport, error) { - report := entities.ImageInspectReport{ - Errors: make(map[string]error), - } - - for _, id := range names { - img, err := ir.Libpod.ImageRuntime().NewFromLocal(id) +func (ir *ImageEngine) Inspect(ctx context.Context, namesOrIDs []string, opts entities.InspectOptions) ([]*entities.ImageInspectReport, error) { + reports := []*entities.ImageInspectReport{} + for _, i := range namesOrIDs { + img, err := ir.Libpod.ImageRuntime().NewFromLocal(i) if err != nil { - report.Errors[id] = err - continue + return nil, err } - - results, err := img.Inspect(ctx) + result, err := img.Inspect(ctx) if err != nil { - report.Errors[id] = err - continue + return nil, err } - - cookedResults := entities.ImageData{} - _ = domainUtils.DeepCopy(&cookedResults, results) - report.Images = append(report.Images, &cookedResults) + report := entities.ImageInspectReport{} + if err := domainUtils.DeepCopy(&report, result); err != nil { + return nil, err + } + reports = append(reports, &report) } - return &report, nil + return reports, nil } func (ir *ImageEngine) Push(ctx context.Context, source string, destination string, options entities.ImagePushOptions) error { |