diff options
author | Karthik Elango <kelango@redhat.com> | 2022-07-27 10:43:06 -0400 |
---|---|---|
committer | Karthik Elango <kelango@redhat.com> | 2022-08-04 09:08:14 -0400 |
commit | 9964366f69a1fbaa709e45c3d3ebcada283a76b7 (patch) | |
tree | f10f06e9e57d59e964f17056edba4f89c1836069 /pkg/domain/infra/tunnel/containers.go | |
parent | 47a814aa6df97da834315d778cb68f66a82c3231 (diff) | |
download | podman-9964366f69a1fbaa709e45c3d3ebcada283a76b7.tar.gz podman-9964366f69a1fbaa709e45c3d3ebcada283a76b7.tar.bz2 podman-9964366f69a1fbaa709e45c3d3ebcada283a76b7.zip |
start filter flag changes
Tying filtering logic for podman stop and start to same place in getContainersAndInputByContext() to reduce code redundancy
Signed-off-by: Karthik Elango <kelango@redhat.com>
Diffstat (limited to 'pkg/domain/infra/tunnel/containers.go')
-rw-r--r-- | pkg/domain/infra/tunnel/containers.go | 31 |
1 files changed, 1 insertions, 30 deletions
diff --git a/pkg/domain/infra/tunnel/containers.go b/pkg/domain/infra/tunnel/containers.go index 98c73c51a..6c1a7f97f 100644 --- a/pkg/domain/infra/tunnel/containers.go +++ b/pkg/domain/infra/tunnel/containers.go @@ -639,36 +639,7 @@ func logIfRmError(id string, err error, reports []*reports.RmReport) { func (ic *ContainerEngine) ContainerStart(ctx context.Context, namesOrIds []string, options entities.ContainerStartOptions) ([]*entities.ContainerStartReport, error) { reports := []*entities.ContainerStartReport{} var exitCode = define.ExecErrorCodeGeneric - containersNamesOrIds := namesOrIds - all := options.All - if len(options.Filters) > 0 { - all = false - containersNamesOrIds = []string{} - opts := new(containers.ListOptions).WithFilters(options.Filters).WithAll(true) - candidates, listErr := containers.List(ic.ClientCtx, opts) - if listErr != nil { - return nil, listErr - } - for _, candidate := range candidates { - if options.All { - containersNamesOrIds = append(containersNamesOrIds, candidate.ID) - continue - } - for _, nameOrID := range namesOrIds { - if nameOrID == candidate.ID { - containersNamesOrIds = append(containersNamesOrIds, nameOrID) - continue - } - for _, containerName := range candidate.Names { - if containerName == nameOrID { - containersNamesOrIds = append(containersNamesOrIds, nameOrID) - continue - } - } - } - } - } - ctrs, err := getContainersByContext(ic.ClientCtx, all, false, containersNamesOrIds) + ctrs, namesOrIds, err := getContainersAndInputByContext(ic.ClientCtx, options.All, false, namesOrIds, options.Filters) if err != nil { return nil, err } |