summaryrefslogtreecommitdiff
path: root/pkg/domain/infra
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2021-10-11 16:09:11 +0200
committerPaul Holzinger <pholzing@redhat.com>2021-10-11 16:13:08 +0200
commite57b32c5956ac4f8cfdbfaabe7b23425a22a08e1 (patch)
tree054fb361535fedbc0fc6533a9bf191f065dea4f4 /pkg/domain/infra
parentea868933e8c014ac52192f397f5dc1c3e8ee375a (diff)
downloadpodman-e57b32c5956ac4f8cfdbfaabe7b23425a22a08e1.tar.gz
podman-e57b32c5956ac4f8cfdbfaabe7b23425a22a08e1.tar.bz2
podman-e57b32c5956ac4f8cfdbfaabe7b23425a22a08e1.zip
podman stats: move cgroup validation to server
Podman stats is not supported for rootless cgroupv1 setups. The check for this must be on the server side and not the client. [NO NEW TESTS NEEDED] we cannot test this because remote and server are always on the same machine in CI Fixes #11909 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'pkg/domain/infra')
-rw-r--r--pkg/domain/infra/abi/containers.go9
1 files changed, 9 insertions, 0 deletions
diff --git a/pkg/domain/infra/abi/containers.go b/pkg/domain/infra/abi/containers.go
index 6ca142618..c30129001 100644
--- a/pkg/domain/infra/abi/containers.go
+++ b/pkg/domain/infra/abi/containers.go
@@ -1319,6 +1319,15 @@ func (ic *ContainerEngine) ContainerStats(ctx context.Context, namesOrIds []stri
if options.Interval < 1 {
return nil, errors.New("Invalid interval, must be a positive number greater zero")
}
+ if rootless.IsRootless() {
+ unified, err := cgroups.IsCgroup2UnifiedMode()
+ if err != nil {
+ return nil, err
+ }
+ if !unified {
+ return nil, errors.New("stats is not supported in rootless mode without cgroups v2")
+ }
+ }
statsChan = make(chan entities.ContainerStatsReport, 1)
containerFunc := ic.Libpod.GetRunningContainers