podmanv2 pod subcommands

add pod kill, pause, restart, rm, start, stop, and unpause

Signed-off-by: Brent Baude <bbaude@redhat.com>

6 files changed, 518 insertions, 4 deletions

diff --git a/pkg/domain/entities/engine_container.go b/pkg/domain/entities/engine_container.go
index 2efdbd602..958061437 100644
--- a/pkg/domain/entities/engine_container.go
+++ b/pkg/domain/entities/engine_container.go
@@ -14,6 +14,13 @@ type ContainerEngine interface {
 	ContainerStop(ctx context.Context, namesOrIds []string, options StopOptions) ([]*StopReport, error)
 	ContainerWait(ctx context.Context, namesOrIds []string, options WaitOptions) ([]WaitReport, error)
 	PodExists(ctx context.Context, nameOrId string) (*BoolReport, error)
+	PodKill(ctx context.Context, namesOrIds []string, options PodKillOptions) ([]*PodKillReport, error)
+	PodPause(ctx context.Context, namesOrIds []string, options PodPauseOptions) ([]*PodPauseReport, error)
+	PodRestart(ctx context.Context, namesOrIds []string, options PodRestartOptions) ([]*PodRestartReport, error)
+	PodStart(ctx context.Context, namesOrIds []string, options PodStartOptions) ([]*PodStartReport, error)
+	PodStop(ctx context.Context, namesOrIds []string, options PodStopOptions) ([]*PodStopReport, error)
+	PodRm(ctx context.Context, namesOrIds []string, options PodRmOptions) ([]*PodRmReport, error)
+	PodUnpause(ctx context.Context, namesOrIds []string, options PodunpauseOptions) ([]*PodUnpauseReport, error)
 	VolumeCreate(ctx context.Context, opts VolumeCreateOptions) (*IdOrNameResponse, error)
 	VolumeInspect(ctx context.Context, namesOrIds []string, opts VolumeInspectOptions) ([]*VolumeInspectReport, error)
 	VolumeRm(ctx context.Context, namesOrIds []string, opts VolumeRmOptions) ([]*VolumeRmReport, error)
diff --git a/pkg/domain/entities/pods.go b/pkg/domain/entities/pods.go
new file mode 100644
index 000000000..8d594620f
--- /dev/null
+++ b/pkg/domain/entities/pods.go
@@ -0,0 +1,94 @@
+package entities
+
+import "time"
+
+type PodKillOptions struct {
+	All    bool
+	Latest bool
+	Signal string
+}
+
+type PodKillReport struct {
+	Errs []error
+	Id   string
+}
+
+type ListPodsReport struct {
+	Cgroup     string
+	Containers []*ListPodContainer
+	Created    time.Time
+	Id         string
+	Name       string
+	Namespace  string
+	Status     string
+}
+
+type ListPodContainer struct {
+	Id     string
+	Names  string
+	Status string
+}
+
+type PodPauseOptions struct {
+	All    bool
+	Latest bool
+}
+
+type PodPauseReport struct {
+	Errs []error
+	Id   string
+}
+
+type PodunpauseOptions struct {
+	All    bool
+	Latest bool
+}
+
+type PodUnpauseReport struct {
+	Errs []error
+	Id   string
+}
+
+type PodStopOptions struct {
+	All     bool
+	Ignore  bool
+	Latest  bool
+	Timeout int
+}
+
+type PodStopReport struct {
+	Errs []error
+	Id   string
+}
+
+type PodRestartOptions struct {
+	All    bool
+	Latest bool
+}
+
+type PodRestartReport struct {
+	Errs []error
+	Id   string
+}
+
+type PodStartOptions struct {
+	All    bool
+	Latest bool
+}
+
+type PodStartReport struct {
+	Errs []error
+	Id   string
+}
+
+type PodRmOptions struct {
+	All    bool
+	Force  bool
+	Ignore bool
+	Latest bool
+}
+
+type PodRmReport struct {
+	Err error
+	Id  string
+}
diff --git a/pkg/domain/infra/abi/images.go b/pkg/domain/infra/abi/images.go
index 203f14987..e3b3e310b 100644
--- a/pkg/domain/infra/abi/images.go
+++ b/pkg/domain/infra/abi/images.go
@@ -46,7 +46,7 @@ func (ir *ImageEngine) Delete(ctx context.Context, nameOrId []string, opts entit
 			err = ir.deleteImage(ctx, img, opts, report)
 			report.Errors = append(report.Errors, err)
 		}
-		if len(targets) >= 0 || len(previousTargets) != 1 {
+		if len(previousTargets) != 1 {
 			goto repeatRun
 		}
 		return &report, nil
@@ -83,9 +83,7 @@ func (ir *ImageEngine) deleteImage(ctx context.Context, img *libpodImage.Image,
 	}
 
 	report.Deleted = append(report.Deleted, results.Deleted)
-	for _, e := range results.Untagged {
-		report.Untagged = append(report.Untagged, e)
-	}
+	report.Untagged = append(report.Untagged, results.Untagged...)
 	return nil
 }
 
diff --git a/pkg/domain/infra/abi/pods.go b/pkg/domain/infra/abi/pods.go
index 8dd7b5a0c..4f68ad5f9 100644
--- a/pkg/domain/infra/abi/pods.go
+++ b/pkg/domain/infra/abi/pods.go
@@ -5,11 +5,45 @@ package abi
 import (
 	"context"
 
+	"github.com/containers/libpod/libpod"
 	"github.com/containers/libpod/libpod/define"
 	"github.com/containers/libpod/pkg/domain/entities"
+	"github.com/containers/libpod/pkg/signal"
 	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
 )
 
+// getPodsByContext returns a slice of pods. Note that all, latest and pods are
+// mutually exclusive arguments.
+func getPodsByContext(all, latest bool, pods []string, runtime *libpod.Runtime) ([]*libpod.Pod, error) {
+	var outpods []*libpod.Pod
+	if all {
+		return runtime.GetAllPods()
+	}
+	if latest {
+		p, err := runtime.GetLatestPod()
+		if err != nil {
+			return nil, err
+		}
+		outpods = append(outpods, p)
+		return outpods, nil
+	}
+	var err error
+	for _, p := range pods {
+		pod, e := runtime.LookupPod(p)
+		if e != nil {
+			// Log all errors here, so callers don't need to.
+			logrus.Debugf("Error looking up pod %q: %v", p, e)
+			if err == nil {
+				err = e
+			}
+		} else {
+			outpods = append(outpods, pod)
+		}
+	}
+	return outpods, err
+}
+
 func (ic *ContainerEngine) PodExists(ctx context.Context, nameOrId string) (*entities.BoolReport, error) {
 	_, err := ic.Libpod.LookupPod(nameOrId)
 	if err != nil && errors.Cause(err) != define.ErrNoSuchPod {
@@ -17,3 +51,191 @@ func (ic *ContainerEngine) PodExists(ctx context.Context, nameOrId string) (*ent
 	}
 	return &entities.BoolReport{Value: err == nil}, nil
 }
+
+func (ic *ContainerEngine) PodKill(ctx context.Context, namesOrIds []string, options entities.PodKillOptions) ([]*entities.PodKillReport, error) {
+	var (
+		reports []*entities.PodKillReport
+	)
+	sig, err := signal.ParseSignalNameOrNumber(options.Signal)
+	if err != nil {
+		return nil, err
+	}
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+
+	for _, p := range pods {
+		report := entities.PodKillReport{Id: p.ID()}
+		conErrs, err := p.Kill(uint(sig))
+		if err != nil {
+			report.Errs = []error{err}
+			reports = append(reports, &report)
+			continue
+		}
+		if len(conErrs) > 0 {
+			for _, err := range conErrs {
+				report.Errs = append(report.Errs, err)
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodPause(ctx context.Context, namesOrIds []string, options entities.PodPauseOptions) ([]*entities.PodPauseReport, error) {
+	var (
+		reports []*entities.PodPauseReport
+	)
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range pods {
+		report := entities.PodPauseReport{Id: p.ID()}
+		errs, err := p.Pause()
+		if err != nil {
+			report.Errs = []error{err}
+			continue
+		}
+		if len(errs) > 0 {
+			for _, v := range errs {
+				report.Errs = append(report.Errs, v)
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodUnpause(ctx context.Context, namesOrIds []string, options entities.PodunpauseOptions) ([]*entities.PodUnpauseReport, error) {
+	var (
+		reports []*entities.PodUnpauseReport
+	)
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range pods {
+		report := entities.PodUnpauseReport{Id: p.ID()}
+		errs, err := p.Unpause()
+		if err != nil {
+			report.Errs = []error{err}
+			continue
+		}
+		if len(errs) > 0 {
+			for _, v := range errs {
+				report.Errs = append(report.Errs, v)
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodStop(ctx context.Context, namesOrIds []string, options entities.PodStopOptions) ([]*entities.PodStopReport, error) {
+	var (
+		reports []*entities.PodStopReport
+	)
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range pods {
+		report := entities.PodStopReport{Id: p.ID()}
+		errs, err := p.StopWithTimeout(ctx, false, options.Timeout)
+		if err != nil {
+			report.Errs = []error{err}
+			continue
+		}
+		if len(errs) > 0 {
+			for _, v := range errs {
+				report.Errs = append(report.Errs, v)
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodRestart(ctx context.Context, namesOrIds []string, options entities.PodRestartOptions) ([]*entities.PodRestartReport, error) {
+	var (
+		reports []*entities.PodRestartReport
+	)
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range pods {
+		report := entities.PodRestartReport{Id: p.ID()}
+		errs, err := p.Restart(ctx)
+		if err != nil {
+			report.Errs = []error{err}
+			continue
+		}
+		if len(errs) > 0 {
+			for _, v := range errs {
+				report.Errs = append(report.Errs, v)
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodStart(ctx context.Context, namesOrIds []string, options entities.PodStartOptions) ([]*entities.PodStartReport, error) {
+	var (
+		reports []*entities.PodStartReport
+	)
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range pods {
+		report := entities.PodStartReport{Id: p.ID()}
+		errs, err := p.Start(ctx)
+		if err != nil {
+			report.Errs = []error{err}
+			continue
+		}
+		if len(errs) > 0 {
+			for _, v := range errs {
+				report.Errs = append(report.Errs, v)
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodRm(ctx context.Context, namesOrIds []string, options entities.PodRmOptions) ([]*entities.PodRmReport, error) {
+	var (
+		reports []*entities.PodRmReport
+	)
+	pods, err := getPodsByContext(options.All, options.Latest, namesOrIds, ic.Libpod)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range pods {
+		report := entities.PodRmReport{Id: p.ID()}
+		err := ic.Libpod.RemovePod(ctx, p, true, options.Force)
+		if err != nil {
+			report.Err = err
+			continue
+		}
+		reports = append(reports, &report)
+	}
+	return reports, nil
+}
diff --git a/pkg/domain/infra/tunnel/helpers.go b/pkg/domain/infra/tunnel/helpers.go
index 11fca5278..f9183c955 100644
--- a/pkg/domain/infra/tunnel/helpers.go
+++ b/pkg/domain/infra/tunnel/helpers.go
@@ -4,9 +4,12 @@ import (
 	"context"
 	"strings"
 
+	"github.com/containers/libpod/libpod/define"
 	"github.com/containers/libpod/pkg/api/handlers/libpod"
 	"github.com/containers/libpod/pkg/bindings"
 	"github.com/containers/libpod/pkg/bindings/containers"
+	"github.com/containers/libpod/pkg/bindings/pods"
+	"github.com/containers/libpod/pkg/domain/entities"
 	"github.com/containers/libpod/pkg/util"
 	"github.com/pkg/errors"
 )
@@ -40,3 +43,34 @@ func getContainersByContext(contextWithConnection context.Context, all bool, nam
 	}
 	return cons, nil
 }
+
+func getPodsByContext(contextWithConnection context.Context, all bool, namesOrIds []string) ([]*entities.ListPodsReport, error) {
+	var (
+		sPods []*entities.ListPodsReport
+	)
+	if all && len(namesOrIds) > 0 {
+		return nil, errors.New("cannot lookup specific pods and all")
+	}
+
+	fPods, err := pods.List(contextWithConnection, nil)
+	if err != nil {
+		return nil, err
+	}
+	if all {
+		return fPods, nil
+	}
+	for _, nameOrId := range namesOrIds {
+		var found bool
+		for _, f := range fPods {
+			if f.Name == nameOrId || strings.HasPrefix(f.Id, nameOrId) {
+				sPods = append(sPods, f)
+				found = true
+				break
+			}
+		}
+		if !found {
+			return nil, errors.Wrapf(define.ErrNoSuchPod, "unable to find pod %q", nameOrId)
+		}
+	}
+	return sPods, nil
+}
diff --git a/pkg/domain/infra/tunnel/pods.go b/pkg/domain/infra/tunnel/pods.go
index 500069d51..53003da42 100644
--- a/pkg/domain/infra/tunnel/pods.go
+++ b/pkg/domain/infra/tunnel/pods.go
@@ -11,3 +11,162 @@ func (ic *ContainerEngine) PodExists(ctx context.Context, nameOrId string) (*ent
 	exists, err := pods.Exists(ic.ClientCxt, nameOrId)
 	return &entities.BoolReport{Value: exists}, err
 }
+
+func (ic *ContainerEngine) PodKill(ctx context.Context, namesOrIds []string, options entities.PodKillOptions) ([]*entities.PodKillReport, error) {
+	var (
+		reports []*entities.PodKillReport
+	)
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range foundPods {
+		response, err := pods.Kill(ic.ClientCxt, p.Id, &options.Signal)
+		if err != nil {
+			report := entities.PodKillReport{
+				Errs: []error{err},
+				Id:   p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodPause(ctx context.Context, namesOrIds []string, options entities.PodPauseOptions) ([]*entities.PodPauseReport, error) {
+	var (
+		reports []*entities.PodPauseReport
+	)
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range foundPods {
+		response, err := pods.Pause(ic.ClientCxt, p.Id)
+		if err != nil {
+			report := entities.PodPauseReport{
+				Errs: []error{err},
+				Id:   p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodUnpause(ctx context.Context, namesOrIds []string, options entities.PodunpauseOptions) ([]*entities.PodUnpauseReport, error) {
+	var (
+		reports []*entities.PodUnpauseReport
+	)
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range foundPods {
+		response, err := pods.Unpause(ic.ClientCxt, p.Id)
+		if err != nil {
+			report := entities.PodUnpauseReport{
+				Errs: []error{err},
+				Id:   p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodStop(ctx context.Context, namesOrIds []string, options entities.PodStopOptions) ([]*entities.PodStopReport, error) {
+	var (
+		reports []*entities.PodStopReport
+		timeout int = -1
+	)
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	if options.Timeout != -1 {
+		timeout = options.Timeout
+	}
+	for _, p := range foundPods {
+		response, err := pods.Stop(ic.ClientCxt, p.Id, &timeout)
+		if err != nil {
+			report := entities.PodStopReport{
+				Errs: []error{err},
+				Id:   p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodRestart(ctx context.Context, namesOrIds []string, options entities.PodRestartOptions) ([]*entities.PodRestartReport, error) {
+	var reports []*entities.PodRestartReport
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range foundPods {
+		response, err := pods.Restart(ic.ClientCxt, p.Id)
+		if err != nil {
+			report := entities.PodRestartReport{
+				Errs: []error{err},
+				Id:   p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodStart(ctx context.Context, namesOrIds []string, options entities.PodStartOptions) ([]*entities.PodStartReport, error) {
+	var reports []*entities.PodStartReport
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range foundPods {
+		response, err := pods.Start(ic.ClientCxt, p.Id)
+		if err != nil {
+			report := entities.PodStartReport{
+				Errs: []error{err},
+				Id:   p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}
+
+func (ic *ContainerEngine) PodRm(ctx context.Context, namesOrIds []string, options entities.PodRmOptions) ([]*entities.PodRmReport, error) {
+	var reports []*entities.PodRmReport
+	foundPods, err := getPodsByContext(ic.ClientCxt, options.All, namesOrIds)
+	if err != nil {
+		return nil, err
+	}
+	for _, p := range foundPods {
+		response, err := pods.Remove(ic.ClientCxt, p.Id, &options.Force)
+		if err != nil {
+			report := entities.PodRmReport{
+				Err: err,
+				Id:  p.Id,
+			}
+			reports = append(reports, &report)
+			continue
+		}
+		reports = append(reports, response)
+	}
+	return reports, nil
+}