diff options
| author | Jhon Honce <jhonce@redhat.com> | 2021-10-05 10:43:55 -0700 |
|---|---|---|
| committer | Jhon Honce <jhonce@redhat.com> | 2021-10-08 13:57:20 -0700 |
| commit | 8d3aec9d08bddf486dcb30e7113777b9d0cc27bd (patch) | |
| tree | e47d47a39f50f7cadaaf0c8bd81f5ed689081b1a /pkg/domain | |
| parent | bd4d9a09520b2329b1cf3dd8cdf8194b8bdeab67 (diff) | |
| download | podman-8d3aec9d08bddf486dcb30e7113777b9d0cc27bd.tar.gz podman-8d3aec9d08bddf486dcb30e7113777b9d0cc27bd.tar.bz2 podman-8d3aec9d08bddf486dcb30e7113777b9d0cc27bd.zip | |
Enable /debug/pprof API service endpoints
* Refactor sidecar HTTP service for /debug/pprof endpoints to use a TCP
address given via new podman system service --pprof-address flag
* Allow same URL parsing in "system service" as bindings/connection.go
* Refactor NewServerWithSettings() to use entities.ServiceOptions
in place of deleted server.Options
* Updated godoc for impacted functions and types
* Fixed API service Shutdown() to do an orderly shutdown when
terminated and running with --time=0
Signed-off-by: Jhon Honce <jhonce@redhat.com>
Diffstat (limited to 'pkg/domain')
| -rw-r--r-- | pkg/domain/entities/system.go | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/pkg/domain/entities/system.go b/pkg/domain/entities/system.go index cca4bf44e..fe041dec8 100644 --- a/pkg/domain/entities/system.go +++ b/pkg/domain/entities/system.go @@ -6,15 +6,14 @@ import ( "github.com/containers/podman/v3/libpod/define" "github.com/containers/podman/v3/pkg/domain/entities/reports" "github.com/containers/podman/v3/pkg/domain/entities/types" - "github.com/spf13/cobra" ) -// ServiceOptions provides the input for starting an API Service +// ServiceOptions provides the input for starting an API and sidecar pprof services type ServiceOptions struct { - URI string // Path to unix domain socket service should listen on - Timeout time.Duration // duration of inactivity the service should wait before shutting down - Command *cobra.Command // CLI command provided. Used in V1 code - CorsHeaders string // CORS headers + CorsHeaders string // Cross-Origin Resource Sharing (CORS) headers + PProfAddr string // Network address to bind pprof profiles service + Timeout time.Duration // Duration of inactivity the service should wait before shutting down + URI string // Path to unix domain socket service should listen on } // SystemPruneOptions provides options to prune system. |