diff options
| author | Valentin Rothberg <vrothberg@redhat.com> | 2022-05-24 13:18:56 +0200 |
|---|---|---|
| committer | Valentin Rothberg <vrothberg@redhat.com> | 2022-05-24 16:07:39 +0200 |
| commit | 5268314e5376c3da7a1123ee1954b466baf2d911 (patch) | |
| tree | e523b93b34538faf7df9562143819eaab18696dd /pkg/domain | |
| parent | d3d3a207de06935f77edd937980e2540f62bc11c (diff) | |
| download | podman-5268314e5376c3da7a1123ee1954b466baf2d911.tar.gz podman-5268314e5376c3da7a1123ee1954b466baf2d911.tar.bz2 podman-5268314e5376c3da7a1123ee1954b466baf2d911.zip | |
podman image mount: print pretty table
Make sure that `podman image mount` prints a pretty table unless there
is only argument passed and without a custom format. Fixing a TODO item
brought me to the specific code location and revealed the fart in the
logic.
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Diffstat (limited to 'pkg/domain')
| -rw-r--r-- | pkg/domain/entities/images.go | 1 | ||||
| -rw-r--r-- | pkg/domain/infra/abi/images.go | 4 |
2 files changed, 0 insertions, 5 deletions
diff --git a/pkg/domain/entities/images.go b/pkg/domain/entities/images.go index 7081c5d25..553be1157 100644 --- a/pkg/domain/entities/images.go +++ b/pkg/domain/entities/images.go @@ -398,7 +398,6 @@ type ImageUnmountOptions struct { // ImageMountReport describes the response from image mount type ImageMountReport struct { - Err error Id string // nolint Name string Repositories []string diff --git a/pkg/domain/infra/abi/images.go b/pkg/domain/infra/abi/images.go index c3ec7dd8a..d469fa0ca 100644 --- a/pkg/domain/infra/abi/images.go +++ b/pkg/domain/infra/abi/images.go @@ -159,10 +159,6 @@ func (ir *ImageEngine) Mount(ctx context.Context, nameOrIDs []string, opts entit mountReports := []*entities.ImageMountReport{} listMountsOnly := !opts.All && len(nameOrIDs) == 0 for _, i := range images { - // TODO: the .Err fields are not used. This pre-dates the - // libimage migration but should be addressed at some point. - // A quick glimpse at cmd/podman/image/mount.go suggests that - // the errors needed to be handled there as well. var mountPoint string var err error if listMountsOnly { |