diff options
| author | Adrian Reber <areber@redhat.com> | 2021-07-12 11:43:45 +0000 |
|---|---|---|
| committer | Adrian Reber <adrian@lisas.de> | 2021-07-27 16:10:44 +0200 |
| commit | eb94467780eab06a452586c9751fc4f571d9e089 (patch) | |
| tree | 7fd60bf5369ae2da6c4661ba2c20e80267abf0c5 /pkg/domain | |
| parent | 3375cbb198c74e895624eada148edff514b64d35 (diff) | |
| download | podman-eb94467780eab06a452586c9751fc4f571d9e089.tar.gz podman-eb94467780eab06a452586c9751fc4f571d9e089.tar.bz2 podman-eb94467780eab06a452586c9751fc4f571d9e089.zip | |
Support checkpoint/restore with pods
This adds support to checkpoint containers out of pods and restore
container into pods.
It is only possible to restore a container into a pod if it has been
checkpointed out of pod. It is also not possible to restore a non pod
container into a pod.
The main reason this does not work is the PID namespace. If a non pod
container is being restored in a pod with a shared PID namespace, at
least one process in the restored container uses PID 1 which is already
in use by the infrastructure container. If someone tries to restore
container from a pod with a shared PID namespace without a shared PID
namespace it will also fail because the resulting PID namespace will not
have a PID 1.
Signed-off-by: Adrian Reber <areber@redhat.com>
Diffstat (limited to 'pkg/domain')
| -rw-r--r-- | pkg/domain/entities/containers.go | 1 | ||||
| -rw-r--r-- | pkg/domain/infra/abi/containers.go | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/pkg/domain/entities/containers.go b/pkg/domain/entities/containers.go index 4d85941cd..6d84a4ecb 100644 --- a/pkg/domain/entities/containers.go +++ b/pkg/domain/entities/containers.go @@ -207,6 +207,7 @@ type RestoreOptions struct { TCPEstablished bool ImportPrevious string PublishPorts []specgen.PortMapping + Pod string } type RestoreReport struct { diff --git a/pkg/domain/infra/abi/containers.go b/pkg/domain/infra/abi/containers.go index 2c89fc66b..2003879b8 100644 --- a/pkg/domain/infra/abi/containers.go +++ b/pkg/domain/infra/abi/containers.go @@ -529,6 +529,7 @@ func (ic *ContainerEngine) ContainerRestore(ctx context.Context, namesOrIds []st IgnoreStaticIP: options.IgnoreStaticIP, IgnoreStaticMAC: options.IgnoreStaticMAC, ImportPrevious: options.ImportPrevious, + Pod: options.Pod, } filterFuncs := []libpod.ContainerFilter{ |