Merge pull request #3521 from baude/golangcilint1

first pass of corrections for golangci-lint

1 files changed, 7 insertions, 2 deletions

diff --git a/pkg/firewall/iptables.go b/pkg/firewall/iptables.go
index 59d81b287..92d249f7b 100644
--- a/pkg/firewall/iptables.go
+++ b/pkg/firewall/iptables.go
@@ -21,6 +21,7 @@ package firewall
 
 import (
 	"fmt"
+	"github.com/sirupsen/logrus"
 	"net"
 
 	"github.com/coreos/go-iptables/iptables"
@@ -53,7 +54,9 @@ func generateFilterRule(privChainName string) []string {
 
 func cleanupRules(ipt *iptables.IPTables, privChainName string, rules [][]string) {
 	for _, rule := range rules {
-		ipt.Delete("filter", privChainName, rule...)
+		if err := ipt.Delete("filter", privChainName, rule...); err != nil {
+			logrus.Errorf("failed to delete iptables rule %s", privChainName)
+		}
 	}
 }
 
@@ -185,7 +188,9 @@ func (ib *iptablesBackend) Add(conf *FirewallNetConf) error {
 
 func (ib *iptablesBackend) Del(conf *FirewallNetConf) error {
 	for proto, ipt := range ib.protos {
-		ib.delRules(conf, ipt, proto)
+		if err := ib.delRules(conf, ipt, proto); err != nil {
+			logrus.Errorf("failed to delete iptables backend rule %s", conf.IptablesAdminChainName)
+		}
 	}
 	return nil
 }