diff options
author | Eng Zer Jun <engzerjun@gmail.com> | 2022-05-05 21:09:41 +0800 |
---|---|---|
committer | Eng Zer Jun <engzerjun@gmail.com> | 2022-05-05 21:09:41 +0800 |
commit | cf35168f0a9cf457f0622cd89cff84bdbe610d58 (patch) | |
tree | db3b776a982b2a6b615a2a7c9ee45ea6f89c9776 /pkg/hooks/monitor_test.go | |
parent | b1e9ea38e5a680afb9294cb8a451311991d94765 (diff) | |
download | podman-cf35168f0a9cf457f0622cd89cff84bdbe610d58.tar.gz podman-cf35168f0a9cf457f0622cd89cff84bdbe610d58.tar.bz2 podman-cf35168f0a9cf457f0622cd89cff84bdbe610d58.zip |
test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Diffstat (limited to 'pkg/hooks/monitor_test.go')
-rw-r--r-- | pkg/hooks/monitor_test.go | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/pkg/hooks/monitor_test.go b/pkg/hooks/monitor_test.go index eed02e033..1067d2920 100644 --- a/pkg/hooks/monitor_test.go +++ b/pkg/hooks/monitor_test.go @@ -15,11 +15,7 @@ import ( func TestMonitorOneDirGood(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) - dir, err := ioutil.TempDir("", "hooks-test-") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(dir) + dir := t.TempDir() manager, err := New(ctx, []string{dir}, []string{}) if err != nil { @@ -114,17 +110,8 @@ func TestMonitorOneDirGood(t *testing.T) { func TestMonitorTwoDirGood(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) - primaryDir, err := ioutil.TempDir("", "hooks-test-primary-") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(primaryDir) - - fallbackDir, err := ioutil.TempDir("", "hooks-test-fallback-") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(fallbackDir) + primaryDir := t.TempDir() + fallbackDir := t.TempDir() manager, err := New(ctx, []string{fallbackDir, primaryDir}, []string{}) if err != nil { |