diff options
author | Ed Santiago <santiago@redhat.com> | 2020-05-24 08:10:54 -0600 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2020-05-24 08:10:54 -0600 |
commit | f75ad6d5c2f1a30c1b72c31fa1ec78280938d0b0 (patch) | |
tree | d57f752cf0b12eec45480255d06441f3a4994c72 /pkg/hooks/read_test.go | |
parent | b4cd54a2fa5f6c0c2239ff619b9b306deed0f6a7 (diff) | |
download | podman-f75ad6d5c2f1a30c1b72c31fa1ec78280938d0b0.tar.gz podman-f75ad6d5c2f1a30c1b72c31fa1ec78280938d0b0.tar.bz2 podman-f75ad6d5c2f1a30c1b72c31fa1ec78280938d0b0.zip |
podman-registry helper script: handle errors
My initial revision of the podman-registry helper script
was written in haste, with an enormous tradeoff: no
visibility into any errors. We are now paying for this
in #6366: the script is failing on Ubuntu and we
have no way of knowing why.
This PR adds a must_pass() function used for critical
steps. This runs the action silently; if the command
fails, it displays the failing command name with
full output logs, cleans up the temporary workdir,
and exits with error status.
As a reminder, the reason this is necessary is that
our script convention is to output a series of
environment variables to stdout -- we must therefore
take pains not to emit anything else to stdout.
And, unfortunately, podman and openssl tend to be
rather verbose.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'pkg/hooks/read_test.go')
0 files changed, 0 insertions, 0 deletions