summaryrefslogtreecommitdiff
path: root/pkg/hooks
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2020-06-17 05:51:04 -0600
committerEd Santiago <santiago@redhat.com>2020-06-17 07:04:00 -0600
commit6d5a432c2e6e538308961b9c130c3aeb32138c7b (patch)
tree648d952668632e4da63dbc7af0e0b2a1be0773f7 /pkg/hooks
parent4fb0f56063de13af53128be9da81027d988516be (diff)
downloadpodman-6d5a432c2e6e538308961b9c130c3aeb32138c7b.tar.gz
podman-6d5a432c2e6e538308961b9c130c3aeb32138c7b.tar.bz2
podman-6d5a432c2e6e538308961b9c130c3aeb32138c7b.zip
"streaming output" logs test: fix flake
Test has been flaking excessively. A quick look shows that the test itself is broken, making a bad assumption. 'podman logs -f' is guaranteed to exit when a container terminates. This does not (and should not) mean that the container has been cleaned up. It is undefined and unsafe to run 'podman run -n same-name-as-terminated-container' immediately after 'podman logs' exits. Solution: instead of 'podman run', do 'podman inspect'. This, too, is unsafe, but we can expect to see one of two possible conditions: 1) command succeeds, in which case we require that container State.Status be "exited"; or 2) command fails, in which case we expect "no such container" in error output For full coverage we should add a small delay-check test to (1) to ensure that the container is cleaned up after a short amount of time. Leaving that as a TODO because it's more than my Go skills can handle, and I want to get this checked in ASAP to get rid of the flake hassle. Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'pkg/hooks')
0 files changed, 0 insertions, 0 deletions