summaryrefslogtreecommitdiff
path: root/pkg/kubeutils
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2021-10-27 17:30:37 +0200
committerValentin Rothberg <rothberg@redhat.com>2021-11-08 10:17:06 +0100
commit9e78185e372b170922dfdad80cede6b351750bb0 (patch)
tree709651a3b890a52fe9ff4ebcdfec16b20395a9a5 /pkg/kubeutils
parent75023e94823d62856aa81bfee605a67907d91438 (diff)
downloadpodman-9e78185e372b170922dfdad80cede6b351750bb0.tar.gz
podman-9e78185e372b170922dfdad80cede6b351750bb0.tar.bz2
podman-9e78185e372b170922dfdad80cede6b351750bb0.zip
volumes: be more tolerant and fix infinite loop
Make Podman more tolerant when parsing image volumes during container creation and further fix an infinite loop when checking them. Consider `VOLUME ['/etc/foo', '/etc/bar']` in a Containerfile. While it looks correct to the human eye, the single quotes are wrong and yield the two volumes to be `[/etc/foo,` and `/etc/bar]` in Podman and Docker. When running the container, it'll create a directory `bar]` in `/etc` and a directory `[` in `/` with two subdirectories `etc/foo,`. This behavior is surprising to me but how Docker behaves. We may improve on that in the future. Note that the correct way to syntax for volumes in a Containerfile is `VOLUME /A /B /C` or `VOLUME ["/A", "/B", "/C"]`; single quotes are not supported. This change restores this behavior without breaking container creation or ending up in an infinite loop. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2014149 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'pkg/kubeutils')
0 files changed, 0 insertions, 0 deletions