diff options
author | Brent Baude <bbaude@redhat.com> | 2022-03-25 14:42:25 -0500 |
---|---|---|
committer | Brent Baude <bbaude@redhat.com> | 2022-03-28 09:12:08 -0500 |
commit | 2ac897aa0dcda012f4fc038c84849d9429d421dc (patch) | |
tree | ac5e7906001e45d682c60b6644f612b60ec7040c /pkg/machine/config.go | |
parent | 54f808e4dd10de0d3ceec7cadac776b119a293b1 (diff) | |
download | podman-2ac897aa0dcda012f4fc038c84849d9429d421dc.tar.gz podman-2ac897aa0dcda012f4fc038c84849d9429d421dc.tar.bz2 podman-2ac897aa0dcda012f4fc038c84849d9429d421dc.zip |
Machine refactor - part 1
the way machine was written was very adjunct and as such is in dire need
of refactoring to better structures and structure methods where
appropriate. the weekest part is specifically around all the files that
machine requires and how some are just dynamically built on the fly.
this pr defines a new machinefile type which allows us to work with the
file and also takes into account the use of symlinks which are going to
be needed on macos due to its relatively short file length restriction.
also, added unit tests for new methods as well as anywhere else I saw a
need.
Signed-off-by: Brent Baude <bbaude@redhat.com>
Diffstat (limited to 'pkg/machine/config.go')
-rw-r--r-- | pkg/machine/config.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/pkg/machine/config.go b/pkg/machine/config.go index aaf8da872..7e1561506 100644 --- a/pkg/machine/config.go +++ b/pkg/machine/config.go @@ -29,7 +29,7 @@ type InitOptions struct { Username string ReExec bool Rootful bool - // The numberical userid of the user that called machine + // The numerical userid of the user that called machine UID string } @@ -128,6 +128,7 @@ type DistributionDownload interface { } func (rc RemoteConnectionType) MakeSSHURL(host, path, port, userName string) url.URL { + //TODO Should this function have input verification? userInfo := url.User(userName) uri := url.URL{ Scheme: "ssh", |