diff options
| author | Paul Holzinger <pholzing@redhat.com> | 2022-04-22 13:38:41 +0200 |
|---|---|---|
| committer | Paul Holzinger <pholzing@redhat.com> | 2022-04-22 15:12:33 +0200 |
| commit | 5b4af0584d1c66b4f8d3d721374541fb76b5b395 (patch) | |
| tree | 0c3a0aa6323ed1a0998784476bfe24c126da5e3a /pkg/machine | |
| parent | 22500d797aba09eada894a69ad88f2699a560d02 (diff) | |
| download | podman-5b4af0584d1c66b4f8d3d721374541fb76b5b395.tar.gz podman-5b4af0584d1c66b4f8d3d721374541fb76b5b395.tar.bz2 podman-5b4af0584d1c66b4f8d3d721374541fb76b5b395.zip | |
replace golint with revive linter
golint, scopelint and interfacer are deprecated. golint is replaced by
revive. This linter is better because it will also check for our error
style: `error strings should not be capitalized or end with punctuation or a newline`
scopelint is replaced by exportloopref (already endabled)
interfacer has no replacement but I do not think this linter is
important.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'pkg/machine')
| -rw-r--r-- | pkg/machine/fcos.go | 4 | ||||
| -rw-r--r-- | pkg/machine/qemu/config.go | 2 | ||||
| -rw-r--r-- | pkg/machine/qemu/machine.go | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/pkg/machine/fcos.go b/pkg/machine/fcos.go index ad1be15c7..d8516dd59 100644 --- a/pkg/machine/fcos.go +++ b/pkg/machine/fcos.go @@ -26,8 +26,8 @@ import ( // These should eventually be moved into machine/qemu as // they are specific to running qemu var ( - artifact string = "qemu" - Format string = "qcow2.xz" + artifact = "qemu" + Format = "qcow2.xz" ) const ( diff --git a/pkg/machine/qemu/config.go b/pkg/machine/qemu/config.go index 6ab25b951..e9416dc36 100644 --- a/pkg/machine/qemu/config.go +++ b/pkg/machine/qemu/config.go @@ -162,7 +162,7 @@ type Monitor struct { var ( // defaultQMPTimeout is the timeout duration for the // qmp monitor interactions. - defaultQMPTimeout time.Duration = 2 * time.Second + defaultQMPTimeout = 2 * time.Second ) // GetPath returns the working path for a machinefile. it returns diff --git a/pkg/machine/qemu/machine.go b/pkg/machine/qemu/machine.go index 4cfd4e8b0..66f5291c1 100644 --- a/pkg/machine/qemu/machine.go +++ b/pkg/machine/qemu/machine.go @@ -907,7 +907,7 @@ func (v *MachineVM) SSH(_ string, opts machine.SSHOptions) error { return err } if state != machine.Running { - return errors.Errorf("vm %q is not running.", v.Name) + return errors.Errorf("vm %q is not running", v.Name) } username := opts.Username |