diff options
author | Matthew Heon <matthew.heon@pm.me> | 2020-05-05 16:19:30 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2020-05-05 20:21:01 -0400 |
commit | f7c3cfde77a4bc8b241fb36c4d39cbe2fde0c45c (patch) | |
tree | 1955cdfcb7ef8705944bcb1b0f8b42286863224e /pkg/specgen/generate/config_linux.go | |
parent | fb6eca50ba9e2dc652da0c33c72db70ab9da85e9 (diff) | |
download | podman-f7c3cfde77a4bc8b241fb36c4d39cbe2fde0c45c.tar.gz podman-f7c3cfde77a4bc8b241fb36c4d39cbe2fde0c45c.tar.bz2 podman-f7c3cfde77a4bc8b241fb36c4d39cbe2fde0c45c.zip |
Add small fixes for 'podman run' from diffing inspect
To try and identify differences between Podman v1.9 and master,
I ran a series of `podman run` commands with various flags
through each, then inspecting the resulting containers and diffed
the inspect JSON between each. This identified a number of issues
which are fixed in this PR.
In order of discovery:
- Podman v2 gave short names for images, where Podman v1 gave the
fully-qualified name. Simple enough fix (get image tags and use
the first one if they're available)
- The --restart flag was not being parsed correctly when a number
of retries was specified. Parsing has been corrected.
- The -m flag was not setting the swap limit (simple fix to set
swap in that case if it's not explicitly set by the user)
- The --cpus flag was completely nonfunctional (wired in its
logic)
Tests have been added for all of these to catch future
regressions.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'pkg/specgen/generate/config_linux.go')
0 files changed, 0 insertions, 0 deletions