enable gocritic linter

The linter ensures a common code style.
- use switch/case instead of else if
- use if instead of switch/case for single case statement
- add space between comment and text
- detect the use of defer with os.Exit()
- use short form var += "..." instead of var = var + "..."
- detect problems with append()
```
newSlice := append(orgSlice, val)
```
  This could lead to nasty bugs because the orgSlice will be changed in
  place if it has enough capacity too hold the new elements. Thus we
  newSlice might not be a copy.

Of course most of the changes are just cosmetic and do not cause any
logic errors but I think it is a good idea to enforce a common style.
This should help maintainability.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/pkg/specgen/generate/container.go b/pkg/specgen/generate/container.go
index 81286b962..831c1d7b9 100644
--- a/pkg/specgen/generate/container.go
+++ b/pkg/specgen/generate/container.go
@@ -395,7 +395,7 @@ func ConfigToSpec(rt *libpod.Runtime, specg *specgen.SpecGenerator, contaierID s
 		} else {
 			switch nameSpaces[i] {
 			case "pid":
-				specg.PidNS = specgen.Namespace{NSMode: specgen.Default} //default
+				specg.PidNS = specgen.Namespace{NSMode: specgen.Default} // default
 			case "net":
 				switch {
 				case conf.NetMode.IsBridge():
@@ -435,7 +435,7 @@ func ConfigToSpec(rt *libpod.Runtime, specg *specgen.SpecGenerator, contaierID s
 					specg.NetNS = specgen.Namespace{NSMode: specgen.FromPod, Value: strings.Split(string(conf.NetMode), ":")[1]}
 				}
 			case "cgroup":
-				specg.CgroupNS = specgen.Namespace{NSMode: specgen.Default} //default
+				specg.CgroupNS = specgen.Namespace{NSMode: specgen.Default} // default
 			case "ipc":
 				switch conf.ShmDir {
 				case "/dev/shm":
@@ -443,15 +443,15 @@ func ConfigToSpec(rt *libpod.Runtime, specg *specgen.SpecGenerator, contaierID s
 				case "":
 					specg.IpcNS = specgen.Namespace{NSMode: specgen.None}
 				default:
-					specg.IpcNS = specgen.Namespace{NSMode: specgen.Default} //default
+					specg.IpcNS = specgen.Namespace{NSMode: specgen.Default} // default
 				}
 			case "uts":
-				specg.UtsNS = specgen.Namespace{NSMode: specgen.Default} //default
+				specg.UtsNS = specgen.Namespace{NSMode: specgen.Default} // default
 			case "user":
 				if conf.AddCurrentUserPasswdEntry {
 					specg.UserNS = specgen.Namespace{NSMode: specgen.KeepID}
 				} else {
-					specg.UserNS = specgen.Namespace{NSMode: specgen.Default} //default
+					specg.UserNS = specgen.Namespace{NSMode: specgen.Default} // default
 				}
 			}
 		}