diff options
author | Matthew Heon <matthew.heon@pm.me> | 2020-04-27 11:46:28 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2020-04-27 13:13:21 -0400 |
commit | 67ec4e1d272d20610f885f91cc322edf57a13f45 (patch) | |
tree | 0e6ea7cd1546791cc85ac6c33947a60076d05c6b /pkg/specgen/generate/container_create.go | |
parent | 02671a103f7991a3c472f90d343a5979f3d3636a (diff) | |
download | podman-67ec4e1d272d20610f885f91cc322edf57a13f45.tar.gz podman-67ec4e1d272d20610f885f91cc322edf57a13f45.tar.bz2 podman-67ec4e1d272d20610f885f91cc322edf57a13f45.zip |
Improve Entrypoint and Command support
We should not be overwriting the Specgen's Command and Entrypoint
when building the final command to pass in the OCI spec. Both of
these will be provided to Libpod for use in `podman inspect` and
committing containers, and both must be set to the user's input,
not overwritten by the image if unset.
Fix this by moving command generation into OCI spec generation
and not modifying the SpecGenerator when we do so.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'pkg/specgen/generate/container_create.go')
-rw-r--r-- | pkg/specgen/generate/container_create.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/specgen/generate/container_create.go b/pkg/specgen/generate/container_create.go index 7de47988d..bb84f0618 100644 --- a/pkg/specgen/generate/container_create.go +++ b/pkg/specgen/generate/container_create.go @@ -108,7 +108,7 @@ func MakeContainer(ctx context.Context, rt *libpod.Runtime, s *specgen.SpecGener } options = append(options, createExitCommandOption(s, rt.StorageConfig(), rtc, podmanPath)) - runtimeSpec, err := SpecGenToOCI(s, rt, rtc, newImage, finalMounts) + runtimeSpec, err := SpecGenToOCI(ctx, s, rt, rtc, newImage, finalMounts) if err != nil { return nil, err } |