summaryrefslogtreecommitdiff
path: root/pkg/specgen/generate
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2022-07-04 17:32:13 +0200
committerPaul Holzinger <pholzing@redhat.com>2022-07-04 17:32:13 +0200
commit5b1867923e1f1787e0675e9a808c3385b6348eee (patch)
tree28e27f0d3be49afa2233481eddfc88b122d41f91 /pkg/specgen/generate
parent3fbe93371258704e56dc741218b4faa399395f8a (diff)
downloadpodman-5b1867923e1f1787e0675e9a808c3385b6348eee.tar.gz
podman-5b1867923e1f1787e0675e9a808c3385b6348eee.tar.bz2
podman-5b1867923e1f1787e0675e9a808c3385b6348eee.zip
TestEnvVarValue: fix assertion
assert.Equal() already follows to pointer and compares by value so we can just directly pass the values. This will make errors much more obvious. Also remove the fmt.Println() since the error now contains the values. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'pkg/specgen/generate')
-rw-r--r--pkg/specgen/generate/kube/play_test.go4
1 files changed, 1 insertions, 3 deletions
diff --git a/pkg/specgen/generate/kube/play_test.go b/pkg/specgen/generate/kube/play_test.go
index e01d62b08..466dab610 100644
--- a/pkg/specgen/generate/kube/play_test.go
+++ b/pkg/specgen/generate/kube/play_test.go
@@ -2,7 +2,6 @@ package kube
import (
"encoding/json"
- "fmt"
"math"
"runtime"
"strconv"
@@ -777,8 +776,7 @@ func TestEnvVarValue(t *testing.T) {
if test.expected == nilString {
assert.Nil(t, result)
} else {
- fmt.Println(*result, test.expected)
- assert.Equal(t, &(test.expected), result)
+ assert.Equal(t, test.expected, *result)
}
})
}