diff options
author | Matthew Heon <matthew.heon@pm.me> | 2020-05-08 13:25:41 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2020-05-08 13:25:41 -0400 |
commit | 7989e422b404c2fe182dac5154fbfe218c561b93 (patch) | |
tree | f6c398b04ea5c5cd863ab8d2643607df4f4c96bb /pkg/specgen/generate | |
parent | 13db0f2b61b17e6f959fff832b40270352cd54da (diff) | |
download | podman-7989e422b404c2fe182dac5154fbfe218c561b93.tar.gz podman-7989e422b404c2fe182dac5154fbfe218c561b93.tar.bz2 podman-7989e422b404c2fe182dac5154fbfe218c561b93.zip |
Fix `podman pod create --infra=false`
We were accidentally setting incorrect defaults for the network
namespace for rootless `pod create` when infra containers were
not being created. This should resolve that issue.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'pkg/specgen/generate')
-rw-r--r-- | pkg/specgen/generate/pod_create.go | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/pkg/specgen/generate/pod_create.go b/pkg/specgen/generate/pod_create.go index df5775f8b..cd2d69cfb 100644 --- a/pkg/specgen/generate/pod_create.go +++ b/pkg/specgen/generate/pod_create.go @@ -5,6 +5,7 @@ import ( "github.com/containers/libpod/libpod" "github.com/containers/libpod/pkg/specgen" + "github.com/pkg/errors" "github.com/sirupsen/logrus" ) @@ -68,15 +69,17 @@ func createPodOptions(p *specgen.PodSpecGenerator) ([]libpod.PodCreateOption, er if p.NoManageResolvConf { options = append(options, libpod.WithPodUseImageResolvConf()) } + if len(p.CNINetworks) > 0 { + options = append(options, libpod.WithPodNetworks(p.CNINetworks)) + } switch p.NetNS.NSMode { - case specgen.Bridge: + case specgen.Bridge, specgen.Default, "": logrus.Debugf("Pod using default network mode") case specgen.Host: logrus.Debugf("Pod will use host networking") options = append(options, libpod.WithPodHostNetwork()) default: - logrus.Debugf("Pod joining CNI networks: %v", p.CNINetworks) - options = append(options, libpod.WithPodNetworks(p.CNINetworks)) + return nil, errors.Errorf("pods presently do not support network mode %s", p.NetNS.NSMode) } if p.NoManageHosts { |