diff options
| author | Giuseppe Scrivano <giuseppe@scrivano.org> | 2022-03-24 17:02:20 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-24 17:02:20 +0100 |
| commit | ab8e15f6ac05a4f35604fa1b2c4f37765aae3007 (patch) | |
| tree | c7cb5c36cca79c25fa2806f9c11b93b86fd409e7 /pkg/specgen | |
| parent | a416fd6de40820e266e9e1e312c5f13bbb0b189f (diff) | |
| parent | aafa80918a245edcbdaceb1191d749570f1872d0 (diff) | |
| download | podman-ab8e15f6ac05a4f35604fa1b2c4f37765aae3007.tar.gz podman-ab8e15f6ac05a4f35604fa1b2c4f37765aae3007.tar.bz2 podman-ab8e15f6ac05a4f35604fa1b2c4f37765aae3007.zip | |
Merge pull request from GHSA-qvf8-p83w-v58j
do not set the inheritable capabilities
Diffstat (limited to 'pkg/specgen')
| -rw-r--r-- | pkg/specgen/generate/security.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/pkg/specgen/generate/security.go b/pkg/specgen/generate/security.go index 9c6709905..988c29832 100644 --- a/pkg/specgen/generate/security.go +++ b/pkg/specgen/generate/security.go @@ -146,6 +146,10 @@ func securityConfigureGenerator(s *specgen.SpecGenerator, g *generate.Generator, configSpec := g.Config configSpec.Process.Capabilities.Ambient = []string{} + + // Always unset the inheritable capabilities similarly to what the Linux kernel does + // They are used only when using capabilities with uid != 0. + configSpec.Process.Capabilities.Inheritable = []string{} configSpec.Process.Capabilities.Bounding = caplist user := strings.Split(s.User, ":")[0] @@ -153,7 +157,6 @@ func securityConfigureGenerator(s *specgen.SpecGenerator, g *generate.Generator, if (user == "" && s.UserNS.NSMode != specgen.KeepID) || user == "root" || user == "0" { configSpec.Process.Capabilities.Effective = caplist configSpec.Process.Capabilities.Permitted = caplist - configSpec.Process.Capabilities.Inheritable = caplist } else { mergedCaps, err := capabilities.MergeCapabilities(nil, s.CapAdd, nil) if err != nil { @@ -175,12 +178,12 @@ func securityConfigureGenerator(s *specgen.SpecGenerator, g *generate.Generator, } configSpec.Process.Capabilities.Effective = userCaps configSpec.Process.Capabilities.Permitted = userCaps - configSpec.Process.Capabilities.Inheritable = userCaps // Ambient capabilities were added to Linux 4.3. Set ambient // capabilities only when the kernel supports them. if supportAmbientCapabilities() { configSpec.Process.Capabilities.Ambient = userCaps + configSpec.Process.Capabilities.Inheritable = userCaps } } |