diff options
| author | Robb Manes <robbmanes@protonmail.com> | 2021-03-16 12:42:02 -0400 |
|---|---|---|
| committer | Robb Manes <robbmanes@protonmail.com> | 2021-03-26 08:53:26 -0400 |
| commit | 748826fc88fcdba373dfcb0986bc3c08b8b858fe (patch) | |
| tree | 06aaecf92bbe6f0af5be514287b1371fc02ddebd /pkg/systemd/generate/common.go | |
| parent | 604459b404ed190f51e8b368c619323317078232 (diff) | |
| download | podman-748826fc88fcdba373dfcb0986bc3c08b8b858fe.tar.gz podman-748826fc88fcdba373dfcb0986bc3c08b8b858fe.tar.bz2 podman-748826fc88fcdba373dfcb0986bc3c08b8b858fe.zip | |
Add RequiresMountsFor= to systemd generate
It is rare but possible that storage locations for the graphroot and the
runroot are not mounted at boot time, and therefore might race when
doing container operations. An example we've seen in the wild is that a
slow tmpfs mount for the runroot would suddenly mount over /run, causing
the container to lose all currently-running data, requiring a system
refresh to get it back.
This patch adds RequiresMountsFor= to the systemd.unit header to ensure
the paths for both the graphroot and runroot are mounted prior to
starting any generated unit files.
Signed-off-by: Robb Manes <rmanes@redhat.com>
Diffstat (limited to 'pkg/systemd/generate/common.go')
| -rw-r--r-- | pkg/systemd/generate/common.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/pkg/systemd/generate/common.go b/pkg/systemd/generate/common.go index 94a6f4cb5..19d468403 100644 --- a/pkg/systemd/generate/common.go +++ b/pkg/systemd/generate/common.go @@ -36,6 +36,7 @@ Description=Podman {{{{.ServiceName}}}}.service Documentation=man:podman-generate-systemd(1) Wants=network.target After=network-online.target +RequiresMountsFor={{{{.GraphRoot}}}} {{{{.RunRoot}}}} ` // filterPodFlags removes --pod and --pod-id-file from the specified command. |