diff options
| author | Valentin Rothberg <rothberg@redhat.com> | 2020-07-09 13:32:20 +0200 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2020-07-22 14:50:47 -0400 |
| commit | 84076bf95f485bccfd9e03108fb69a1f72b42918 (patch) | |
| tree | ff7e5ac8be9598f65fa23c7b8df9bceb99dc584b /pkg/varlinkapi | |
| parent | f9526cf02b76f1c006bd344d05e8a40bfe94dbe9 (diff) | |
| download | podman-84076bf95f485bccfd9e03108fb69a1f72b42918.tar.gz podman-84076bf95f485bccfd9e03108fb69a1f72b42918.tar.bz2 podman-84076bf95f485bccfd9e03108fb69a1f72b42918.zip | |
log API: add context to allow for cancelling
Add a `context.Context` to the log APIs to allow for cancelling
streaming (e.g., via `podman logs -f`). This fixes issues for
the remote API where some go routines of the server will continue
writing and produce nothing but heat and waste CPU cycles.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'pkg/varlinkapi')
| -rw-r--r-- | pkg/varlinkapi/containers.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/varlinkapi/containers.go b/pkg/varlinkapi/containers.go index 8650ba000..07b492331 100644 --- a/pkg/varlinkapi/containers.go +++ b/pkg/varlinkapi/containers.go @@ -754,7 +754,7 @@ func (i *VarlinkAPI) GetContainersLogs(call iopodman.VarlinkCall, names []string if err != nil { return call.ReplyErrorOccurred(err.Error()) } - if err := i.Runtime.Log(containers, &options, logChannel); err != nil { + if err := i.Runtime.Log(getContext(), containers, &options, logChannel); err != nil { return err } go func() { |