summaryrefslogtreecommitdiff
path: root/pkg
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2021-07-27 12:00:15 +0200
committerValentin Rothberg <rothberg@redhat.com>2021-07-27 12:00:15 +0200
commit7689783ae53aa29a79c2e98d6f59711bfcf0efcf (patch)
treee2947cfd575e3aa7779d8b2bf00860c007fd492f /pkg
parentd7b2f03f8a5d0e3789ac185ea03989463168fb76 (diff)
downloadpodman-7689783ae53aa29a79c2e98d6f59711bfcf0efcf.tar.gz
podman-7689783ae53aa29a79c2e98d6f59711bfcf0efcf.tar.bz2
podman-7689783ae53aa29a79c2e98d6f59711bfcf0efcf.zip
exec: fix cleanup
Commit 341e6a1 made sure that all exec sessions are getting cleaned up. But it also came with a peformance penalty. Fix that penalty by spawning the cleanup process to really only cleanup the exec session without attempting to remove the container. [NO TESTS NEEDED] since we have no means to test such performance issues in CI. Fixes: #10701 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Diffstat (limited to 'pkg')
-rw-r--r--pkg/domain/infra/abi/containers.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg/domain/infra/abi/containers.go b/pkg/domain/infra/abi/containers.go
index 485ab944d..2c89fc66b 100644
--- a/pkg/domain/infra/abi/containers.go
+++ b/pkg/domain/infra/abi/containers.go
@@ -618,7 +618,7 @@ func makeExecConfig(options entities.ExecOptions, rt *libpod.Runtime) (*libpod.E
return nil, errors.Wrapf(err, "error retrieving Libpod configuration to build exec exit command")
}
// TODO: Add some ability to toggle syslog
- exitCommandArgs, err := generate.CreateExitCommandArgs(storageConfig, runtimeConfig, false, true, true)
+ exitCommandArgs, err := generate.CreateExitCommandArgs(storageConfig, runtimeConfig, false, false, true)
if err != nil {
return nil, errors.Wrapf(err, "error constructing exit command for exec session")
}