summaryrefslogtreecommitdiff
path: root/pkg
diff options
context:
space:
mode:
authorPaul Holzinger <pholzing@redhat.com>2021-09-15 15:36:00 +0200
committerMatthew Heon <matthew.heon@pm.me>2021-09-22 15:45:41 -0400
commitd27fcbdc21a4c5fc201997068f871cf1e91561a1 (patch)
tree437f0ed508d38ba325662d378510a966b71c0d81 /pkg
parent1a25a90a4ec01fb254b617a8350683cbf28c6ca5 (diff)
downloadpodman-d27fcbdc21a4c5fc201997068f871cf1e91561a1.tar.gz
podman-d27fcbdc21a4c5fc201997068f871cf1e91561a1.tar.bz2
podman-d27fcbdc21a4c5fc201997068f871cf1e91561a1.zip
container runlabel remove image tag from name
When no name is given for podman container runlabel it will default to the image base name. However this can contain a tag. Since podman does not accept container names with a colon the run command will fail if it contains something like `podman run --name NAME ...`. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2004263 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'pkg')
-rw-r--r--pkg/domain/infra/abi/containers_runlabel.go3
1 files changed, 3 insertions, 0 deletions
diff --git a/pkg/domain/infra/abi/containers_runlabel.go b/pkg/domain/infra/abi/containers_runlabel.go
index d448627dc..435baa8c8 100644
--- a/pkg/domain/infra/abi/containers_runlabel.go
+++ b/pkg/domain/infra/abi/containers_runlabel.go
@@ -133,6 +133,9 @@ func generateRunlabelCommand(runlabel string, img *libimage.Image, inputName str
}
splitImageName := strings.Split(normalize, "/")
name = splitImageName[len(splitImageName)-1]
+ // make sure to remove the tag from the image name, otherwise the name cannot
+ // be used as container name because a colon is an illegal character
+ name = strings.SplitN(name, ":", 2)[0]
}
// Append the user-specified arguments to the runlabel (command).