turn hidden --trace into a NOP

The --trace has helped in early stages analyze Podman code.  However,
it's contributing to dependency and binary bloat.  The standard go
tooling can also help in profiling, so let's turn `--trace` into a NOP.

[NO TESTS NEEDED]

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

2 files changed, 13 insertions, 49 deletions

diff --git a/pkg/domain/entities/engine.go b/pkg/domain/entities/engine.go
index f23d964e5..af996ad1e 100644
--- a/pkg/domain/entities/engine.go
+++ b/pkg/domain/entities/engine.go
@@ -1,11 +1,7 @@
 package entities
 
 import (
-	"context"
-	"io"
-
 	"github.com/containers/common/pkg/config"
-	"github.com/opentracing/opentracing-go"
 	"github.com/spf13/pflag"
 )
 
@@ -37,22 +33,19 @@ type PodmanConfig struct {
 	*config.Config
 	*pflag.FlagSet
 
-	CGroupUsage    string           // rootless code determines Usage message
-	ConmonPath     string           // --conmon flag will set Engine.ConmonPath
-	CPUProfile     string           // Hidden: Should CPU profile be taken
-	EngineMode     EngineMode       // ABI or Tunneling mode
-	Identity       string           // ssh identity for connecting to server
-	MaxWorks       int              // maximum number of parallel threads
-	RegistriesConf string           // allows for specifying a custom registries.conf
-	Remote         bool             // Connection to Podman API Service will use RESTful API
-	RuntimePath    string           // --runtime flag will set Engine.RuntimePath
-	RuntimeFlags   []string         // global flags for the container runtime
-	Span           opentracing.Span // tracing object
-	SpanCloser     io.Closer        // Close() for tracing object
-	SpanCtx        context.Context  // context to use when tracing
-	Syslog         bool             // write to StdOut and Syslog, not supported when tunneling
-	Trace          bool             // Hidden: Trace execution
-	URI            string           // URI to RESTful API Service
+	CGroupUsage    string     // rootless code determines Usage message
+	ConmonPath     string     // --conmon flag will set Engine.ConmonPath
+	CPUProfile     string     // Hidden: Should CPU profile be taken
+	EngineMode     EngineMode // ABI or Tunneling mode
+	Identity       string     // ssh identity for connecting to server
+	MaxWorks       int        // maximum number of parallel threads
+	RegistriesConf string     // allows for specifying a custom registries.conf
+	Remote         bool       // Connection to Podman API Service will use RESTful API
+	RuntimePath    string     // --runtime flag will set Engine.RuntimePath
+	RuntimeFlags   []string   // global flags for the container runtime
+	Syslog         bool       // write to StdOut and Syslog, not supported when tunneling
+	Trace          bool       // Hidden: Trace execution
+	URI            string     // URI to RESTful API Service
 
 	Runroot       string
 	StorageDriver string
diff --git a/pkg/tracing/tracing.go b/pkg/tracing/tracing.go
deleted file mode 100644
index 5be24faaa..000000000
--- a/pkg/tracing/tracing.go
+++ /dev/null
@@ -1,29 +0,0 @@
-package tracing
-
-import (
-	"fmt"
-	"io"
-
-	"github.com/opentracing/opentracing-go"
-	"github.com/uber/jaeger-client-go"
-	"github.com/uber/jaeger-client-go/config"
-)
-
-// Init returns an instance of Jaeger Tracer that samples 100% of traces and logs all spans to stdout.
-func Init(service string) (opentracing.Tracer, io.Closer) {
-	cfg := &config.Configuration{
-		ServiceName: service,
-		Sampler: &config.SamplerConfig{
-			Type:  "const",
-			Param: 1,
-		},
-		Reporter: &config.ReporterConfig{
-			LogSpans: true,
-		},
-	}
-	tracer, closer, err := cfg.NewTracer(config.Logger(jaeger.StdLogger))
-	if err != nil {
-		panic(fmt.Sprintf("ERROR: cannot init Jaeger: %v\n", err))
-	}
-	return tracer, closer
-}