summaryrefslogtreecommitdiff
path: root/pkg
diff options
context:
space:
mode:
authorCharlie Doern <cdoern@redhat.com>2022-06-28 09:49:44 -0400
committerCharlie Doern <cdoern@redhat.com>2022-06-28 10:09:38 -0400
commit6c4c050d3df4f4e952273891bddfeb5b5bd8be5e (patch)
treeadd21fe8a6f35c9b12796f24c0bfb02c1147666b /pkg
parent4274906a80c830492e0634602350c1626288e968 (diff)
downloadpodman-6c4c050d3df4f4e952273891bddfeb5b5bd8be5e.tar.gz
podman-6c4c050d3df4f4e952273891bddfeb5b5bd8be5e.tar.bz2
podman-6c4c050d3df4f4e952273891bddfeb5b5bd8be5e.zip
fix volume reporting in system df
currently, podman system df incorrectly calculates the reclaimable storage for volumes, using a cumulative reclaimable variable that is incremented and placed into each report entry causing values to rise above 100%. Switch this variables to be in the context of the loop, so it resets per volume just like the size variable does. resolves #13516 Signed-off-by: Charlie Doern <cdoern@redhat.com>
Diffstat (limited to 'pkg')
-rw-r--r--pkg/domain/infra/abi/system.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/pkg/domain/infra/abi/system.go b/pkg/domain/infra/abi/system.go
index 6e26026d4..2bd88ed85 100644
--- a/pkg/domain/infra/abi/system.go
+++ b/pkg/domain/infra/abi/system.go
@@ -319,8 +319,8 @@ func (ic *ContainerEngine) SystemDf(ctx context.Context, options entities.System
}
dfVolumes := make([]*entities.SystemDfVolumeReport, 0, len(vols))
- var reclaimableSize uint64
for _, v := range vols {
+ var reclaimableSize uint64
var consInUse int
mountPoint, err := v.MountPoint()
if err != nil {
@@ -341,7 +341,7 @@ func (ic *ContainerEngine) SystemDf(ctx context.Context, options entities.System
return nil, err
}
if len(inUse) == 0 {
- reclaimableSize += volSize
+ reclaimableSize = volSize
}
for _, viu := range inUse {
if cutil.StringInSlice(viu, runningContainers) {