API v2 tests: catch up to moving target

Lots has changed since I first checked this in:

 * Switch to new podman system service invocation
 * /containers API has changed drastically
 * /pods API has some fixes; check for them (e.g.
   container-exists is now 409 Conflict, not 500)
 * One test ('?invalidparam=x') still doesn't work;
   comment it out so we can get everything passing.

Also, some work on the test framework itself:

 * Cleaner port-open testing (the bash /dev/tcp check).
 * Add a 'podman' function to invoke local podman and
   log its output.

The above two allow us to:

 * Get rid of stderr special-casing

Furthermore:

 * t() no longer needs leading '.'; this allows jq
   features such as 'length' and perhaps other filters
 * special-case handling of 204 and 304: rfc2616 demands
   that they return no message body; assert that it is so.
 * new root & rootless helper functions (check server)
 * remove the "unlikely to work" message for rootless;
   it seems to be working fine
 * fix pod tests for rootless
   * BUT: add a bolder FIXME because the ID field seems wrong

Signed-off-by: Ed Santiago <santiago@redhat.com>

1 files changed, 16 insertions, 4 deletions

diff --git a/test/apiv2/40-pods.at b/test/apiv2/40-pods.at
index 1c25a3822..705de94d2 100644
--- a/test/apiv2/40-pods.at
+++ b/test/apiv2/40-pods.at
@@ -3,19 +3,31 @@
 # test pod-related endpoints
 #
 
+# FIXME! Shouldn't /create give an actual pod ID?
+expected_id='machine.slice'
+if rootless; then
+    expected_id=/libpod_parent
+fi
+
 t GET  libpod/pods/json            200 null
-t POST libpod/pods/create name=foo 201 '{"id":"machine.slice"}'   # FIXME!
+t POST libpod/pods/create name=foo 201 .id=$expected_id
 t GET  libpod/pods/foo/exists      204
 t GET  libpod/pods/notfoo/exists   404
 t GET  libpod/pods/foo/json        200     .Config.name=foo     .Containers=null
 t GET  libpod/pods/json            200 .[0].Config.name=foo .[0].Containers=null
 
-# Cannot create a dup pod with the same name (FIXME: should that be 409?)
-t POST libpod/pods/create name=foo 500 .cause="pod already exists"
+# Cannot create a dup pod with the same name
+t POST libpod/pods/create name=foo 409 .cause="pod already exists"
 
 #t POST libpod/pods/create a=b 400 .cause='bad parameter'  # FIXME: unimplemented
 
-t POST libpod/pods/foo/pause   '' 204
+if root; then
+    t POST libpod/pods/foo/pause   '' 204
+else
+    t POST libpod/pods/foo/pause '' 500 \
+      .cause="this container does not have a cgroup" \
+      .message~".*pause pods containing rootless containers with cgroup V1"
+fi
 t POST libpod/pods/foo/unpause '' 200
 t POST libpod/pods/foo/unpause '' 200   # (2nd time)
 t POST libpod/pods/foo/stop    '' 304