summaryrefslogtreecommitdiff
path: root/test/e2e/build_test.go
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2020-09-23 08:09:31 -0600
committerEd Santiago <santiago@redhat.com>2020-09-23 08:09:31 -0600
commitb7147afde914aa32d4ab05a271d078be2d236885 (patch)
tree694691bbabf007311607a7d52893ca57caf0677a /test/e2e/build_test.go
parent3059bf8ef0877092c1b924cc1069ac9b3a1ebc2f (diff)
downloadpodman-b7147afde914aa32d4ab05a271d078be2d236885.tar.gz
podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.bz2
podman-b7147afde914aa32d4ab05a271d078be2d236885.zip
e2e tests: SkipIfRemote(): add a reason
Now that Dan has added helpful comments to each SkipIfRemote, let's take the next step and include those messages in the Skip() output so someone viewing test results can easily see if a remote test is skipped for a real reason or for a FIXME. This commit is the result of a simple: perl -pi -e 's;(SkipIfRemote)\(\)(\s+//\s+(.*))?;$1("$3");' *.go in the test/e2e directory, with a few minor (manual) changes in wording. Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/build_test.go')
-rw-r--r--test/e2e/build_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/e2e/build_test.go b/test/e2e/build_test.go
index 0307b7dbc..e3e1044aa 100644
--- a/test/e2e/build_test.go
+++ b/test/e2e/build_test.go
@@ -89,7 +89,7 @@ var _ = Describe("Podman build", func() {
// Check that builds with different values for the squash options
// create the appropriate number of layers, then clean up after.
It("podman build basic alpine with squash", func() {
- SkipIfRemote() // FIXME: This is broken should be fixed
+ SkipIfRemote("FIXME: This is broken should be fixed")
session := podmanTest.PodmanNoCache([]string{"build", "-f", "build/squash/Dockerfile.squash-a", "-t", "test-squash-a:latest", "build/squash"})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Equal(0))
@@ -221,7 +221,7 @@ var _ = Describe("Podman build", func() {
})
It("podman build --http_proxy flag", func() {
- SkipIfRemote() // FIXME: This is broken should be fixed
+ SkipIfRemote("FIXME: This is broken should be fixed")
os.Setenv("http_proxy", "1.2.3.4")
podmanTest.RestoreAllArtifacts()
dockerfile := `FROM docker.io/library/alpine:latest