diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-04-27 14:58:46 -0600 |
|---|---|---|
| committer | Matthew Heon <matthew.heon@pm.me> | 2022-05-03 13:38:21 -0400 |
| commit | ecc39b5958d4a51fa701932b98fab0a45f4c1893 (patch) | |
| tree | 32e2c50b13979970a85ca5336f937f886f2bd16f /test/e2e/commit_test.go | |
| parent | e5d6b6b0a2cfdbb21506b8f5e741cf719c149cb4 (diff) | |
| download | podman-ecc39b5958d4a51fa701932b98fab0a45f4c1893.tar.gz podman-ecc39b5958d4a51fa701932b98fab0a45f4c1893.tar.bz2 podman-ecc39b5958d4a51fa701932b98fab0a45f4c1893.zip | |
Ginkgo: use HaveField() for better error checking
This is a very late followup to my ginkgo-improving work of 2021.
It has been stuck since December because it requires gomega 1.17,
which we've just enabled.
This commit is simply a copy-paste of a command I saved in
my TODO list many months ago:
sed -i -e 's/Expect(\([^ ]\+\)\.\([a-zA-Z0-9]\+\))\.To(Equal(/Expect(\1).To(HaveField(\"\2\", /' test/e2e/*_test.go
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/commit_test.go')
| -rw-r--r-- | test/e2e/commit_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/e2e/commit_test.go b/test/e2e/commit_test.go index 78b607f1e..1de30e423 100644 --- a/test/e2e/commit_test.go +++ b/test/e2e/commit_test.go @@ -92,7 +92,7 @@ var _ = Describe("Podman commit", func() { check := podmanTest.Podman([]string{"inspect", "foobar.com/test1-image:latest"}) check.WaitWithDefaultTimeout() data := check.InspectImageJSON() - Expect(data[0].Comment).To(Equal("testing-commit")) + Expect(data[0]).To(HaveField("Comment", "testing-commit")) }) It("podman commit container with author", func() { @@ -107,7 +107,7 @@ var _ = Describe("Podman commit", func() { check := podmanTest.Podman([]string{"inspect", "foobar.com/test1-image:latest"}) check.WaitWithDefaultTimeout() data := check.InspectImageJSON() - Expect(data[0].Author).To(Equal("snoopy")) + Expect(data[0]).To(HaveField("Author", "snoopy")) }) It("podman commit container with change flag", func() { @@ -293,7 +293,7 @@ var _ = Describe("Podman commit", func() { check := podmanTest.Podman([]string{"inspect", "foobar.com/test1-image:latest"}) check.WaitWithDefaultTimeout() data := check.InspectImageJSON() - Expect(data[0].ID).To(Equal(string(id))) + Expect(data[0]).To(HaveField("ID", string(id))) }) It("podman commit should not commit secret", func() { |