diff options
| author | Ed Santiago <santiago@redhat.com> | 2021-11-22 10:54:22 -0700 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2021-11-22 14:37:43 -0700 |
| commit | 97ab9176f77c4fc9c4413afad4d2dcf5fad824b6 (patch) | |
| tree | fc67f0c7dd3304489f89fd58742d3c46431eb44a /test/e2e/pod_infra_container_test.go | |
| parent | 1bfbb28b0365790552483b961b4bd48a69dd8070 (diff) | |
| download | podman-97ab9176f77c4fc9c4413afad4d2dcf5fad824b6.tar.gz podman-97ab9176f77c4fc9c4413afad4d2dcf5fad824b6.tar.bz2 podman-97ab9176f77c4fc9c4413afad4d2dcf5fad824b6.zip | |
e2e tests: clean up antihelpful BeTrue()s
Many ginkgo tests have been written to use this evil form:
GrepString("foo")
Expect(that to BeTrue())
...which yields horrible useless messages on failure:
false is not true
Identify those (automatically, via script) and convert to:
Expect(output to ContainSubstring("foo"))
...which yields:
"this output" does not contain substring "foo"
There are still many BeTrue()s left. This is just a start.
This is commit 1 of 2. It includes the script I used, and
all changes to *.go are those computed by the script.
Commit 2 will apply some manual fixes.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/pod_infra_container_test.go')
| -rw-r--r-- | test/e2e/pod_infra_container_test.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/e2e/pod_infra_container_test.go b/test/e2e/pod_infra_container_test.go index 3bd7f48ab..6d57c3887 100644 --- a/test/e2e/pod_infra_container_test.go +++ b/test/e2e/pod_infra_container_test.go @@ -42,8 +42,7 @@ var _ = Describe("Podman pod create", func() { check := podmanTest.Podman([]string{"pod", "ps", "-q", "--no-trunc"}) check.WaitWithDefaultTimeout() - match, _ := check.GrepString(podID) - Expect(match).To(BeTrue()) + Expect(check.OutputToString()).To(ContainSubstring(podID)) Expect(len(check.OutputToStringArray())).To(Equal(1)) check = podmanTest.Podman([]string{"ps", "-qa", "--no-trunc"}) |