diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-04-27 14:58:46 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2022-04-28 05:41:53 -0600 |
| commit | b3f38c31b29b51440edd5913a90019efbced0862 (patch) | |
| tree | 72749f8e3ddedee0bb882c186a7f3cee08fe5f1c /test/e2e/pod_inspect_test.go | |
| parent | 2b8cafc0671fbbd155770f044b8216f050877192 (diff) | |
| download | podman-b3f38c31b29b51440edd5913a90019efbced0862.tar.gz podman-b3f38c31b29b51440edd5913a90019efbced0862.tar.bz2 podman-b3f38c31b29b51440edd5913a90019efbced0862.zip | |
Ginkgo: use HaveField() for better error checking
This is a very late followup to my ginkgo-improving work of 2021.
It has been stuck since December because it requires gomega 1.17,
which we've just enabled.
This commit is simply a copy-paste of a command I saved in
my TODO list many months ago:
sed -i -e 's/Expect(\([^ ]\+\)\.\([a-zA-Z0-9]\+\))\.To(Equal(/Expect(\1).To(HaveField(\"\2\", /' test/e2e/*_test.go
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/pod_inspect_test.go')
| -rw-r--r-- | test/e2e/pod_inspect_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/e2e/pod_inspect_test.go b/test/e2e/pod_inspect_test.go index 19a2772fd..dcc70e4a5 100644 --- a/test/e2e/pod_inspect_test.go +++ b/test/e2e/pod_inspect_test.go @@ -58,7 +58,7 @@ var _ = Describe("Podman pod inspect", func() { Expect(inspect).Should(Exit(0)) Expect(inspect.OutputToString()).To(BeValidJSON()) podData := inspect.InspectPodToJSON() - Expect(podData.ID).To(Equal(podid)) + Expect(podData).To(HaveField("ID", podid)) }) It("podman pod inspect (CreateCommand)", func() { @@ -98,7 +98,7 @@ var _ = Describe("Podman pod inspect", func() { Expect(err).To(BeNil()) Expect(inspectJSON.InfraConfig).To(Not(BeNil())) Expect(inspectJSON.InfraConfig.PortBindings["80/tcp"]).To(HaveLen(1)) - Expect(inspectJSON.InfraConfig.PortBindings["80/tcp"][0].HostPort).To(Equal("8383")) + Expect(inspectJSON.InfraConfig.PortBindings["80/tcp"][0]).To(HaveField("HostPort", "8383")) }) It("podman pod inspect outputs show correct MAC", func() { |