diff options
| author | Ed Santiago <santiago@redhat.com> | 2021-11-22 13:28:43 -0700 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2021-11-22 15:23:08 -0700 |
| commit | 49d63ad5c120919ff6669baae2ebbd2b81f5c11a (patch) | |
| tree | 90d0bdcb144a8fb74d75c93fa518b573309cf74f /test/e2e/port_test.go | |
| parent | 97ab9176f77c4fc9c4413afad4d2dcf5fad824b6 (diff) | |
| download | podman-49d63ad5c120919ff6669baae2ebbd2b81f5c11a.tar.gz podman-49d63ad5c120919ff6669baae2ebbd2b81f5c11a.tar.bz2 podman-49d63ad5c120919ff6669baae2ebbd2b81f5c11a.zip | |
Oops! Manual edits to broken tests
Commit 2 of 2: there were (still are?) a bunch of string
checks that didn't have a corresponding Expect(). IIUC
that means they were NOPs. Try to identify and fix those.
The first few were caught by Go linting, "ok is defined
but not used". When I realized the problem, I looked for
more using:
$ ack -A2 LineInOutputStartsWith
...and tediously eyeballing the results, looking for
matches in which the next line was not Expect(). If
test was wrong (e.g. "server" should've been "nameserver"),
fix that.
Also: remove the remove-betrue script. We don't need it
in the repo, I just wanted to preserve it for posterity.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/port_test.go')
| -rw-r--r-- | test/e2e/port_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/e2e/port_test.go b/test/e2e/port_test.go index b502fa61f..776687113 100644 --- a/test/e2e/port_test.go +++ b/test/e2e/port_test.go @@ -125,7 +125,7 @@ var _ = Describe("Podman port", func() { result := podmanTest.Podman([]string{"port", "portcheck"}) result.WaitWithDefaultTimeout() Expect(result).Should(Exit(0)) - result.LineInOutputStartsWith("80/tcp -> 0.0.0.0:") + Expect(result.OutputToStringArray()).To(ContainElement(HavePrefix("80/tcp -> 0.0.0.0:"))) }) It("podman port multiple ports", func() { |