summaryrefslogtreecommitdiff
path: root/test/e2e/run_dns_test.go
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2021-11-22 10:54:22 -0700
committerEd Santiago <santiago@redhat.com>2021-11-22 14:37:43 -0700
commit97ab9176f77c4fc9c4413afad4d2dcf5fad824b6 (patch)
treefc67f0c7dd3304489f89fd58742d3c46431eb44a /test/e2e/run_dns_test.go
parent1bfbb28b0365790552483b961b4bd48a69dd8070 (diff)
downloadpodman-97ab9176f77c4fc9c4413afad4d2dcf5fad824b6.tar.gz
podman-97ab9176f77c4fc9c4413afad4d2dcf5fad824b6.tar.bz2
podman-97ab9176f77c4fc9c4413afad4d2dcf5fad824b6.zip
e2e tests: clean up antihelpful BeTrue()s
Many ginkgo tests have been written to use this evil form: GrepString("foo") Expect(that to BeTrue()) ...which yields horrible useless messages on failure: false is not true Identify those (automatically, via script) and convert to: Expect(output to ContainSubstring("foo")) ...which yields: "this output" does not contain substring "foo" There are still many BeTrue()s left. This is just a start. This is commit 1 of 2. It includes the script I used, and all changes to *.go are those computed by the script. Commit 2 will apply some manual fixes. Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/run_dns_test.go')
-rw-r--r--test/e2e/run_dns_test.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/e2e/run_dns_test.go b/test/e2e/run_dns_test.go
index 166160ad2..01f40b1fc 100644
--- a/test/e2e/run_dns_test.go
+++ b/test/e2e/run_dns_test.go
@@ -97,7 +97,7 @@ var _ = Describe("Podman run dns", func() {
session := podmanTest.Podman([]string{"run", "-t", "-i", "--hostname=foobar", ALPINE, "cat", "/etc/hosts"})
session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0))
- Expect(session.LineInOutputContains("foobar")).To(BeTrue())
+ Expect(session.OutputToString()).To(ContainSubstring("foobar"))
})
It("podman run mutually excludes --dns* and --network", func() {