diff options
author | Ed Santiago <santiago@redhat.com> | 2020-09-23 08:09:31 -0600 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2020-09-23 08:09:31 -0600 |
commit | b7147afde914aa32d4ab05a271d078be2d236885 (patch) | |
tree | 694691bbabf007311607a7d52893ca57caf0677a /test/e2e/run_env_test.go | |
parent | 3059bf8ef0877092c1b924cc1069ac9b3a1ebc2f (diff) | |
download | podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.gz podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.bz2 podman-b7147afde914aa32d4ab05a271d078be2d236885.zip |
e2e tests: SkipIfRemote(): add a reason
Now that Dan has added helpful comments to each SkipIfRemote,
let's take the next step and include those messages in the
Skip() output so someone viewing test results can easily
see if a remote test is skipped for a real reason or for
a FIXME.
This commit is the result of a simple:
perl -pi -e 's;(SkipIfRemote)\(\)(\s+//\s+(.*))?;$1("$3");' *.go
in the test/e2e directory, with a few minor (manual) changes
in wording.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/run_env_test.go')
-rw-r--r-- | test/e2e/run_env_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/e2e/run_env_test.go b/test/e2e/run_env_test.go index 08a7438be..3f488ada5 100644 --- a/test/e2e/run_env_test.go +++ b/test/e2e/run_env_test.go @@ -90,7 +90,7 @@ var _ = Describe("Podman run", func() { }) It("podman run --env-host environment test", func() { - SkipIfRemote() // FIXME, We should check that --env-host reports correct error on podman-remote + SkipIfRemote("FIXME, We should check that --env-host reports correct error on podman-remote") env := append(os.Environ(), "FOO=BAR") session := podmanTest.PodmanAsUser([]string{"run", "--rm", "--env-host", ALPINE, "/bin/printenv", "FOO"}, 0, 0, "", env) @@ -108,7 +108,7 @@ var _ = Describe("Podman run", func() { }) It("podman run --http-proxy test", func() { - SkipIfRemote() // FIXME: Should report proper error when http-proxy is not supported + SkipIfRemote("FIXME: Should report proper error when http-proxy is not supported") os.Setenv("http_proxy", "1.2.3.4") session := podmanTest.Podman([]string{"run", "--rm", ALPINE, "printenv", "http_proxy"}) session.WaitWithDefaultTimeout() |