diff options
author | Ed Santiago <santiago@redhat.com> | 2021-11-23 11:12:34 -0700 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2021-11-29 08:30:00 -0700 |
commit | b63d696405593d056cce850e1503a6bef17c2cf8 (patch) | |
tree | 77aa079636ea326eec76520734e0ae9e815ca6c2 /test/e2e/run_privileged_test.go | |
parent | 3d19f1a7fac5705518693cad3f2c7f94dcc2f1d4 (diff) | |
download | podman-b63d696405593d056cce850e1503a6bef17c2cf8.tar.gz podman-b63d696405593d056cce850e1503a6bef17c2cf8.tar.bz2 podman-b63d696405593d056cce850e1503a6bef17c2cf8.zip |
e2e tests: enable golint
...and fix problems found therewith.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/run_privileged_test.go')
-rw-r--r-- | test/e2e/run_privileged_test.go | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/test/e2e/run_privileged_test.go b/test/e2e/run_privileged_test.go index d793a01f8..321bf27ac 100644 --- a/test/e2e/run_privileged_test.go +++ b/test/e2e/run_privileged_test.go @@ -21,18 +21,18 @@ func containerCapMatchesHost(ctrCap string, hostCap string) { if isRootless() { return } - ctrCap_n, err := strconv.ParseUint(ctrCap, 16, 64) + ctrCapN, err := strconv.ParseUint(ctrCap, 16, 64) Expect(err).NotTo(HaveOccurred(), "Error parsing %q as hex", ctrCap) - hostCap_n, err := strconv.ParseUint(hostCap, 16, 64) + hostCapN, err := strconv.ParseUint(hostCap, 16, 64) Expect(err).NotTo(HaveOccurred(), "Error parsing %q as hex", hostCap) // host caps can never be zero (except rootless). // and host caps must always be a superset (inclusive) of container - Expect(hostCap_n).To(BeNumerically(">", 0), "host cap %q should be nonzero", hostCap) - Expect(hostCap_n).To(BeNumerically(">=", ctrCap_n), "host cap %q should never be less than container cap %q", hostCap, ctrCap) - hostCap_masked := hostCap_n & (1<<len(capability.List()) - 1) - Expect(ctrCap_n).To(Equal(hostCap_masked), "container cap %q is not a subset of host cap %q", ctrCap, hostCap) + Expect(hostCapN).To(BeNumerically(">", 0), "host cap %q should be nonzero", hostCap) + Expect(hostCapN).To(BeNumerically(">=", ctrCapN), "host cap %q should never be less than container cap %q", hostCap, ctrCap) + hostCapMasked := hostCapN & (1<<len(capability.List()) - 1) + Expect(ctrCapN).To(Equal(hostCapMasked), "container cap %q is not a subset of host cap %q", ctrCap, hostCap) } var _ = Describe("Podman privileged container tests", func() { |