summaryrefslogtreecommitdiff
path: root/test/e2e/run_staticip_test.go
diff options
context:
space:
mode:
authorJhon Honce <jhonce@redhat.com>2019-10-04 10:09:24 -0700
committerJhon Honce <jhonce@redhat.com>2019-10-16 08:10:07 -0700
commit60d0be17fc55404929ad24d861f318968997458f (patch)
treee6aeecf49dd00a8e1f4a32cb3c0638b041fb0572 /test/e2e/run_staticip_test.go
parent7825c5827e039aed6656f5df65de2262591681e6 (diff)
downloadpodman-60d0be17fc55404929ad24d861f318968997458f.tar.gz
podman-60d0be17fc55404929ad24d861f318968997458f.tar.bz2
podman-60d0be17fc55404929ad24d861f318968997458f.zip
Refactor tests when checking for error exit codes
Rather than checking for non-zero, we need to check for >0 to distinguish between timeouts and error exit codes. Signed-off-by: Jhon Honce <jhonce@redhat.com>
Diffstat (limited to 'test/e2e/run_staticip_test.go')
-rw-r--r--test/e2e/run_staticip_test.go8
1 files changed, 4 insertions, 4 deletions
diff --git a/test/e2e/run_staticip_test.go b/test/e2e/run_staticip_test.go
index 7a877ebdc..5b4842fea 100644
--- a/test/e2e/run_staticip_test.go
+++ b/test/e2e/run_staticip_test.go
@@ -40,19 +40,19 @@ var _ = Describe("Podman run with --ip flag", func() {
It("Podman run --ip with garbage address", func() {
result := podmanTest.Podman([]string{"run", "-ti", "--ip", "114232346", ALPINE, "ls"})
result.WaitWithDefaultTimeout()
- Expect(result.ExitCode()).ToNot(Equal(0))
+ Expect(result).To(ExitWithError())
})
It("Podman run --ip with v6 address", func() {
result := podmanTest.Podman([]string{"run", "-ti", "--ip", "2001:db8:bad:beef::1", ALPINE, "ls"})
result.WaitWithDefaultTimeout()
- Expect(result.ExitCode()).ToNot(Equal(0))
+ Expect(result).To(ExitWithError())
})
It("Podman run --ip with non-allocatable IP", func() {
result := podmanTest.Podman([]string{"run", "-ti", "--ip", "203.0.113.124", ALPINE, "ls"})
result.WaitWithDefaultTimeout()
- Expect(result.ExitCode()).ToNot(Equal(0))
+ Expect(result).To(ExitWithError())
})
It("Podman run with specified static IP has correct IP", func() {
@@ -70,6 +70,6 @@ var _ = Describe("Podman run with --ip flag", func() {
Expect(result.ExitCode()).To(Equal(0))
result = podmanTest.Podman([]string{"run", "-ti", "--ip", ip, ALPINE, "ip", "addr"})
result.WaitWithDefaultTimeout()
- Expect(result.ExitCode()).ToNot(Equal(0))
+ Expect(result).To(ExitWithError())
})
})