summaryrefslogtreecommitdiff
path: root/test/e2e/run_test.go
diff options
context:
space:
mode:
authorEd Santiago <santiago@redhat.com>2020-09-23 08:09:31 -0600
committerEd Santiago <santiago@redhat.com>2020-09-23 08:09:31 -0600
commitb7147afde914aa32d4ab05a271d078be2d236885 (patch)
tree694691bbabf007311607a7d52893ca57caf0677a /test/e2e/run_test.go
parent3059bf8ef0877092c1b924cc1069ac9b3a1ebc2f (diff)
downloadpodman-b7147afde914aa32d4ab05a271d078be2d236885.tar.gz
podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.bz2
podman-b7147afde914aa32d4ab05a271d078be2d236885.zip
e2e tests: SkipIfRemote(): add a reason
Now that Dan has added helpful comments to each SkipIfRemote, let's take the next step and include those messages in the Skip() output so someone viewing test results can easily see if a remote test is skipped for a real reason or for a FIXME. This commit is the result of a simple: perl -pi -e 's;(SkipIfRemote)\(\)(\s+//\s+(.*))?;$1("$3");' *.go in the test/e2e directory, with a few minor (manual) changes in wording. Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/run_test.go')
-rw-r--r--test/e2e/run_test.go14
1 files changed, 7 insertions, 7 deletions
diff --git a/test/e2e/run_test.go b/test/e2e/run_test.go
index d4ff96939..c8655dcad 100644
--- a/test/e2e/run_test.go
+++ b/test/e2e/run_test.go
@@ -59,7 +59,7 @@ var _ = Describe("Podman run", func() {
})
It("podman run --signature-policy", func() {
- SkipIfRemote() // SigPolicy not handled by remote
+ SkipIfRemote("SigPolicy not handled by remote")
session := podmanTest.Podman([]string{"run", "--pull=always", "--signature-policy", "/no/such/file", ALPINE})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Not(Equal(0)))
@@ -295,7 +295,7 @@ var _ = Describe("Podman run", func() {
})
It("podman run user capabilities test with image", func() {
- SkipIfRemote() // FIXME This should work on podman-remote
+ SkipIfRemote("FIXME This should work on podman-remote")
dockerfile := `FROM busybox
USER bin`
podmanTest.BuildImage(dockerfile, "test", "false")
@@ -343,7 +343,7 @@ USER bin`
})
It("podman run limits host test", func() {
- SkipIfRemote() // This can only be used for local tests
+ SkipIfRemote("This can only be used for local tests")
var l syscall.Rlimit
@@ -486,7 +486,7 @@ USER bin`
})
It("podman run notify_socket", func() {
- SkipIfRemote() // This can only be used for local tests
+ SkipIfRemote("This can only be used for local tests")
host := GetHostDistributionInfo()
if host.Distribution != "rhel" && host.Distribution != "centos" && host.Distribution != "fedora" {
@@ -546,7 +546,7 @@ USER bin`
})
It("podman run with secrets", func() {
- SkipIfRemote() // FIXME This should work on podman-remote
+ SkipIfRemote("FIXME This should work on podman-remote")
containersDir := filepath.Join(podmanTest.TempDir, "containers")
err := os.MkdirAll(containersDir, 0755)
Expect(err).To(BeNil())
@@ -711,7 +711,7 @@ USER bin`
})
It("podman run with built-in volume image", func() {
- SkipIfRemote() // FIXME This should work on podman-remote
+ SkipIfRemote("FIXME This should work on podman-remote")
session := podmanTest.Podman([]string{"run", "--rm", redis, "ls"})
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Equal(0))
@@ -1028,7 +1028,7 @@ USER mail`
})
It("podman run with restart-policy always restarts containers", func() {
- SkipIfRemote() // FIXME This should work on podman-remote
+ SkipIfRemote("FIXME This should work on podman-remote")
testDir := filepath.Join(podmanTest.RunRoot, "restart-test")
err := os.MkdirAll(testDir, 0755)
Expect(err).To(BeNil())