diff options
author | Ed Santiago <santiago@redhat.com> | 2020-09-23 08:09:31 -0600 |
---|---|---|
committer | Ed Santiago <santiago@redhat.com> | 2020-09-23 08:09:31 -0600 |
commit | b7147afde914aa32d4ab05a271d078be2d236885 (patch) | |
tree | 694691bbabf007311607a7d52893ca57caf0677a /test/e2e/search_test.go | |
parent | 3059bf8ef0877092c1b924cc1069ac9b3a1ebc2f (diff) | |
download | podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.gz podman-b7147afde914aa32d4ab05a271d078be2d236885.tar.bz2 podman-b7147afde914aa32d4ab05a271d078be2d236885.zip |
e2e tests: SkipIfRemote(): add a reason
Now that Dan has added helpful comments to each SkipIfRemote,
let's take the next step and include those messages in the
Skip() output so someone viewing test results can easily
see if a remote test is skipped for a real reason or for
a FIXME.
This commit is the result of a simple:
perl -pi -e 's;(SkipIfRemote)\(\)(\s+//\s+(.*))?;$1("$3");' *.go
in the test/e2e directory, with a few minor (manual) changes
in wording.
Signed-off-by: Ed Santiago <santiago@redhat.com>
Diffstat (limited to 'test/e2e/search_test.go')
-rw-r--r-- | test/e2e/search_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/e2e/search_test.go b/test/e2e/search_test.go index d85d4ebf0..a3d56ad89 100644 --- a/test/e2e/search_test.go +++ b/test/e2e/search_test.go @@ -237,7 +237,7 @@ registries = ['{{.Host}}:{{.Port}}']` }) It("podman search attempts HTTP if registry is in registries.insecure and force secure is false", func() { - SkipIfRemote() // FIXME This should work on podman-remote + SkipIfRemote("FIXME This should work on podman-remote") if podmanTest.Host.Arch == "ppc64le" { Skip("No registry image for ppc64le") } @@ -278,7 +278,7 @@ registries = ['{{.Host}}:{{.Port}}']` }) It("podman search doesn't attempt HTTP if force secure is true", func() { - SkipIfRemote() // FIXME This should work on podman-remote + SkipIfRemote("FIXME This should work on podman-remote") if podmanTest.Host.Arch == "ppc64le" { Skip("No registry image for ppc64le") } @@ -317,7 +317,7 @@ registries = ['{{.Host}}:{{.Port}}']` }) It("podman search doesn't attempt HTTP if registry is not listed as insecure", func() { - SkipIfRemote() // FIXME This should work on podman-remote + SkipIfRemote("FIXME This should work on podman-remote") if podmanTest.Host.Arch == "ppc64le" { Skip("No registry image for ppc64le") } @@ -356,7 +356,7 @@ registries = ['{{.Host}}:{{.Port}}']` }) It("podman search doesn't attempt HTTP if one registry is not listed as insecure", func() { - SkipIfRemote() // FIXME This should work on podman-remote + SkipIfRemote("FIXME This should work on podman-remote") if podmanTest.Host.Arch == "ppc64le" { Skip("No registry image for ppc64le") } |